-
Notifications
You must be signed in to change notification settings - Fork 164
fix(api): Fix boolean query params, search pollution, and OpenAPI schemas #2207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
- Fix boolean query parameters showing empty values in API tester (e.g., `?clean=` instead of `?clean=true`). The issue was in the `explode: true` handling where `Object.entries()` was called on primitive values parsed from JSON. - Move API clients box from decorator to direct React rendering, preventing "Clients" heading from appearing in search results. - Update docusaurus-theme-openapi-docs and docusaurus-plugin-openapi-docs to 4.7.1, and @redocly/cli to 2.15.0. - Skip apiKey auth schemes in API tester (only support httpBearer). - Improve code signing: skip silently when APIFY_SIGNING_TOKEN is missing instead of spamming logs. - Fix deprecation warning by moving onBrokenMarkdownLinks to markdown.hooks. - Style improvements for the API clients box. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
Preview for this PR was built for commit |
…tion Similar to the clients box fix, render LLMButtons directly via swizzled ApiItem component instead of injecting into markdown content. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Add unevaluated properties that caused validation failures after @redocly/cli 2.15.0 update with stricter validation: - Run.yaml: metamorphs as array of Metamorph objects - RunMeta.yaml: clientIp, userAgent, scheduleId, scheduledAt - Version.yaml: gitRepoUrl, tarballUrl, gitHubGistUrl - CreateOrUpdateVersionRequest.yaml: same as Version.yaml - DatasetSchemaValidationError.yaml: restructured with type/message/data - RequestDraft.yaml: id property - StoreListActor.yaml: isWhiteListedForAgenticPayment - New Metamorph.yaml schema for metamorph event details Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
Preview for this PR was built for commit |
Instead of swizzling ApiItem (which didn't work with the openapi theme), render LLMButtons via the existing patch using a React portal that positions it after the heading element. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
90496d8 to
b506312
Compare
|
Preview for this PR was built for commit |
|
Preview for this PR was built for commit |
|
Could you please explain how the missing schemas happened? Did they get lost during the recent updates? If not, how did you discover that they're missing? |
|
I updated redocly, I think they weren’t checking this before. |
janbuchar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand the docs code, but the changes to the spec look good to me
|
Preview for this PR was built for commit |
|
They indeed do, but its not related to the changes from this PR. Let me try to fix that too. |
The API clients box was appearing in the .md versions of API pages. Wrapping it in BrowserOnly ensures it only renders client-side. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
89c21b3 to
09d67d1
Compare
|
Preview for this PR was built for commit |
- Show Example tab first (before Schema) - Skip auto-generated example when explicit example exists - Expand first level of nested schema items by default Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
Preview for this PR was built for commit |
Patch files contain git hashes that trigger false positives. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
Preview for this PR was built for commit |
|
I've found one more saved convo from slack about this, and added final improvement:
|
|
Preview for this PR was built for commit |
Closes #1174 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
Preview for this PR was built for commit |
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
Preview for this PR was built for commit |
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
Preview for this PR was built for commit |
|
Should be ready to merge. I went through the existing issues and tried to fix a few more things. |

Summary
?clean=instead of?clean=true)Test plan
cleanparam).mdexport.mdexportnpm run openapi:lint:redocly)🤖 Generated with Claude Code
Closes #2204
Closes #1983
Closes #1943
Closes #1327
Closes #1174