SPICE-0028: Add support for multi-line string line continuations#1507
Open
HT154 wants to merge 1 commit intoapple:mainfrom
Open
SPICE-0028: Add support for multi-line string line continuations#1507HT154 wants to merge 1 commit intoapple:mainfrom
HT154 wants to merge 1 commit intoapple:mainfrom
Conversation
HT154
force-pushed
the
string-multiline-continuation
branch
from
cfecef2 to
a0f96db
Compare
HT154
changed the title
HT154
changed the title
HT154
force-pushed
the
string-multiline-continuation
branch
5 times, most recently
from
e3503d4 to
4ea2208
Compare
bioball
requested changes
Apr 15, 2026
Member
bioball
left a comment
bioball
left a comment
There was a problem hiding this comment.
Looks good! Just some minor comments.
Can we also add a parser error test for whitespace after line continuation?
bioball
reviewed
Apr 15, 2026
HT154
force-pushed
the
string-multiline-continuation
branch
from
4ea2208 to
04410e3
Compare
HT154
force-pushed
the
string-multiline-continuation
branch
from
04410e3 to
4fdd089
Compare
bioball
approved these changes
Apr 16, 2026
Member
bioball
left a comment
bioball
left a comment
There was a problem hiding this comment.
LGTM!
Also looking for a thumb from @stackoverflow
| –– Pkl Error –– | ||
| Invalid character escape sequence `\ `. | ||
|
|
||
| Valid character escape sequences are: \n \r \t \" \\ |
Member
There was a problem hiding this comment.
Can we add some sort of hint that string continuation is also valid?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SPICE: apple/pkl-evolution#31