-
Notifications
You must be signed in to change notification settings - Fork 373
SPICE-0028: Add support for multi-line string line continuations #1507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
HT154
wants to merge
1
commit into
apple:main
Choose a base branch
from
HT154:string-multiline-continuation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 changes: 21 additions & 0 deletions
21
pkl-core/src/test/files/LanguageSnippetTests/input/basic/stringMultilineContinuation.pkl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| amends "../snippetTest.pkl" | ||
|
|
||
| examples { | ||
| ["string continuation"] { | ||
| """ | ||
| hello \ | ||
| world | ||
| """ | ||
|
|
||
| #""" | ||
| hello \# | ||
| world | ||
| """# | ||
|
|
||
| """ | ||
| hello \ | ||
| \ | ||
| world | ||
| """ | ||
| } | ||
| } |
5 changes: 5 additions & 0 deletions
5
pkl-core/src/test/files/LanguageSnippetTests/input/errors/parser19.pkl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| foo = """ | ||
| hello \ | ||
| \ | ||
| world | ||
| """ |
2 changes: 2 additions & 0 deletions
2
pkl-core/src/test/files/LanguageSnippetTests/input/errors/parser20.pkl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| foo = "hello \ | ||
| world" |
5 changes: 5 additions & 0 deletions
5
pkl-core/src/test/files/LanguageSnippetTests/input/errors/parser21.pkl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| foo = | ||
| """ | ||
| hello \ | ||
| world | ||
| """ |
7 changes: 7 additions & 0 deletions
7
pkl-core/src/test/files/LanguageSnippetTests/output/basic/stringMultilineContinuation.pcf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| examples { | ||
| ["string continuation"] { | ||
| "hello world" | ||
| "hello world" | ||
| "hello world" | ||
| } | ||
| } |
6 changes: 6 additions & 0 deletions
6
pkl-core/src/test/files/LanguageSnippetTests/output/errors/parser19.err
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| –– Pkl Error –– | ||
| Line must match or exceed indentation of the String's last line. | ||
|
|
||
| x | \ | ||
| ^ | ||
| at parser19 (file:///$snippetsDir/input/errors/parser19.pkl) |
8 changes: 8 additions & 0 deletions
8
pkl-core/src/test/files/LanguageSnippetTests/output/errors/parser20.err
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| –– Pkl Error –– | ||
| Invalid line continuation escape sequence. | ||
|
|
||
| Line continuations are only allowed in multi-line strings. | ||
|
|
||
| x | foo = "hello \ | ||
| ^^ | ||
| at parser20 (file:///$snippetsDir/input/errors/parser20.pkl) |
8 changes: 8 additions & 0 deletions
8
pkl-core/src/test/files/LanguageSnippetTests/output/errors/parser21.err
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| –– Pkl Error –– | ||
| Invalid character escape sequence `\ `. | ||
|
|
||
| Valid character escape sequences are: \n \r \t \" \\ | ||
|
|
||
| x | hello \ | ||
| ^^ | ||
| at parser21 (file:///$snippetsDir/input/errors/parser21.pkl) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add some sort of hint that string continuation is also valid?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm given that
\nis already present here, any ideas on how to communicate this?\«newline»?