fix(webhook): Correctly enable serialize feature on all enabled crates #667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzeitlin11
approved these changes
Feb 9, 2025
There was a problem hiding this comment.
Thanks @robko23! Just like your other PR, if you can rebase, CI should be good, then I'll merge it!
|
@mzeitlin11 @arlyon I have rebased to 4dbe007 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #663
Summary
When I enabled
serializeordeserializefeature flag onasync-stripe-webhookwith some kind of extra dependency (for exampleasync-stripe-checkout), it resulted in compilation error, becauseserializefeature was not enabled on any of those extra packages