test: Cover IfStmt float condition and VariableDeclaration zero-init paths by Jaskirat-s7 · Pull Request #236 · arxlang/irx

Jaskirat-s7 · 2026-03-17T12:33:34Z

Summary

Phase 2 coverage improvements for issue #38.

Changes

1. tests/test_if_stmt.py

Added Float32 to the int_type parametrize in test_if_else_stmt and test_if_only_stmt, covering the fcmp_ordered float condition path in the IfStmt visitor (llvmliteir.py lines 1191–1193).

2. tests/test_variable_assignment.py

Added test_variable_declaration_no_initializer — parametrized for Int32 and Float32 — covering the zero-init fallback in the VariableDeclaration visitor (llvmliteir.py lines 3049–3059).

3. Bug fix in llvmliteir.py

VariableDeclaration checked node.value is not None, but astx defaults value to astx.Undefined() (not None), making the zero-init path unreachable. Fixed by also checking isinstance(node.value, astx.Undefined).

Coverage Impact

llvmliteir.py: 84% → 85% (16 uncovered lines removed)
Overall project coverage: 85% → 86%
4 new tests added

Closes part of #38

Jaskirat-s7 · 2026-03-17T13:05:45Z

@yuvimittal , PR ready for a review!

Jaskirat-s7 · 2026-03-17T13:26:22Z

Hi @yuvimittal
Quick overview of how this addresses the improvements you proposed:
Smaller scope ->breaking issue #38 into phases. This PR only touches IfStmt float comparisons and VariableDeclaration zero-init.
Real assertions -> every test compiles the IR, runs it through Clang, and checks actual output. Not just "did the builder crash."
Proper file placement -> the tests live in test_if_stmt.py and test_variable_assignment.py where they belong, not in a generic coverage file.
pytest.mark.parametrize -> the missing fcmp_ordered float branch was covered just by adding (astx.Float32, astx.LiteralFloat32) to the existing parametrize matrices. @xmnlab's suggestion from last time made that really clean to do — no bloated boilerplate needed.
Let me know what you think!

yuvimittal · 2026-03-18T09:41:17Z

@Jaskirat-s7 , generally when we make a branch, we name it starting feature- nameofbranch

yuvimittal · 2026-03-18T09:52:15Z

tests/test_if_stmt.py

        (astx.Int16, astx.LiteralInt16),
        (astx.Int8, astx.LiteralInt8),
        (astx.Int64, astx.LiteralInt64),
+        (astx.Float32, astx.LiteralFloat32),


lets add float64 as well?

Done! Added (astx.Float64, astx.LiteralFloat64) to both test_if_else_stmt and test_if_only_stmt parametrize lists.

Jaskirat-s7 · 2026-03-18T10:10:42Z

Hey @yuvimittal — quick question on workflow before I start Phase 4.

Phase 3 PR (#239) is currently stacked on top of Phase 2 (#236). This works for now, but as I continue toward 90% coverage, I'm wondering what's preferred:

Option A — Keep stacking: Branch Phase 4 from Phase 3, Phase 5 from Phase 4, etc. Downside is that any change to Phase 2 forces a rebase cascade through all later phases.

Option B — Branch independently from main: Open a sub-issue for Phase 4, branch directly from main, and keep each PR self-contained. This means Phase 4 may have slight duplication in scope with the unmerged Phase 2/3 commits, but would be much easier to review and merge independently.
Happy to go whichever direction works best.

yuvimittal · 2026-03-19T08:29:16Z

tests/test_variable_assignment.py

+
+    module.block.append(fn_main)
+
+    check_result("build", builder, module)


For this test to be useful, it should assert "0" for Int32 and "0.0" (or "0.000000", depending on how your IR formats it) for Float32. Without that, the test only checks that the build doesn't crash, not that it defaults to zero.

i have added PrintExpr to print x and asserted "0" for Int32 and "0.000000" for Float32/Float64. The test now proves the default-to-zero behavior at runtime, not just that the build doesn't crash , also i added Float64 to the parametrize list.

yuvimittal · 2026-03-19T08:30:39Z

tests/test_variable_assignment.py

+def test_variable_declaration_no_initializer(
+    builder_class: type[Builder],
+    var_type: type,
+    literal_type: type,


why have you added this? this seems unused?

You're right , literal_type was left over from the original structure and wasn't used anywhere in the function body. Removed it from the parametrize tuple, function signature, and docstring. All 3 cases still pass.

yuvimittal · 2026-03-19T08:31:44Z

tests/test_variable_assignment.py

+    "var_type, literal_type",
+    [
+        (astx.Int32, astx.LiteralInt32),
+        (astx.Float32, astx.LiteralFloat32),


@pytest.mark.parametrize( "var_type, expected_output", [ (astx.Int8, "0"), (astx.Int16, "0"), (astx.Int32, "0"), (astx.Int64, "0"), (astx.Float32, "0.0"), (astx.Float64, "0.0"), ], )
If zero-initialization is a general contract of your IR, you should cover more types for consistency

i have added Int8, Int16, and Int64 alongside the existing Int32, Float32, Float64 , all 6 types now assert "0" (integers) or "0.000000" (floats) at runtime. All pass.

yuvimittal · 2026-03-19T08:32:17Z

tests/test_variable_assignment.py

add float datatype here as well

it was already included in the previous commit , Float32 and Float64 are in the parametrize list with "42.000000" as the expected output.

Jaskirat-s7 · 2026-03-19T20:21:50Z

@yuvimittal , i have added PrintExpr + expected_output assertion ('0' for ints, '0.000000' for floats) to prove zero-default at runtime, not just build success also removed unused literal_type parameter from signature and parametrize and added Int8, Int16, Int64 alongside Int32/Float32/Float64 for consistency

…n zero-init paths - Add Float32 to test_if_else_stmt and test_if_only_stmt parametrize lists - Add test_variable_declaration_no_initializer for Int32 and Float32 - Fix: VariableDeclaration visitor checked 'node.value is not None' but astx defaults value to astx.Undefined(); added isinstance check so uninitialized vars reach the zero-init path (llvmliteir.py lines 3023-3059)

…eedback

… review

…tion_no_initializer Add PrintExpr and expected_output assertion ('0' for Int32, '0.000000' for Float32/Float64) so the test proves default-to-zero behavior at runtime, not just that the build does not crash. Also add Float64 to the parametrize list.

… review - add PrintExpr + expected_output assertion ('0' for ints, '0.000000' for floats) to prove zero-default at runtime, not just build success - remove unused literal_type parameter from signature and parametrize - add Int8, Int16, Int64 alongside Int32/Float32/Float64 for consistency

xmnlab · 2026-03-31T20:10:26Z

thanks @Jaskirat-s7

github-actions · 2026-04-02T04:15:35Z

🎉 This PR is included in version 1.9.0 🎉

The release is available on:

1.9.0
GitHub release

Your semantic-release bot 📦🚀

yuvimittal changed the title ~~test(#38): cover IfStmt float condition and VariableDeclaration zero-init paths~~ test: Cover IfStmt float condition and VariableDeclaration zero-init paths Mar 18, 2026

yuvimittal reviewed Mar 18, 2026

View reviewed changes

yuvimittal requested changes Mar 19, 2026

View reviewed changes

Jaskirat-s7 force-pushed the test/issue-38-uninit-var-fix branch from 1537186 to 58792ba Compare March 19, 2026 20:19

Jaskirat-s7 and others added 9 commits March 31, 2026 17:45

fix: add missing Type import in test_variable_assignment.py

a809fd7

test(arxlang#38): add Float64 to IfStmt parametrize list per review f…

357c5b2

…eedback

Fix commented-out test case in variable assignment test

0db9c57

Fix comment formatting in test_variable_assignment.py

bb3aa82

test(arxlang#38): add Float32/Float64 to test_variable_assignment per…

718fcb0

… review

ci: re-run jobs

38fb079

xmnlab force-pushed the test/issue-38-uninit-var-fix branch from 9b267fa to 38fb079 Compare March 31, 2026 17:46

fix small issues

65e3dfa

xmnlab merged commit 2987609 into arxlang:main Mar 31, 2026
13 checks passed

github-actions bot added the released label Apr 2, 2026


		module.block.append(fn_main)

		check_result("build", builder, module)

Conversation

Jaskirat-s7 commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

1. tests/test_if_stmt.py

2. tests/test_variable_assignment.py

3. Bug fix in llvmliteir.py

Coverage Impact

Uh oh!

Jaskirat-s7 commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Jaskirat-s7 commented Mar 17, 2026

Uh oh!

yuvimittal commented Mar 18, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Jaskirat-s7 commented Mar 18, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yuvimittal Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Jaskirat-s7 commented Mar 19, 2026

Uh oh!

Uh oh!

xmnlab commented Mar 31, 2026

Uh oh!

github-actions bot commented Apr 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Jaskirat-s7 commented Mar 17, 2026 •

edited

Loading

Jaskirat-s7 commented Mar 17, 2026 •

edited

Loading

yuvimittal Mar 19, 2026 •

edited

Loading