Skip to content

test: Cover IfStmt float condition and VariableDeclaration zero-init paths #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xmnlab merged 10 commits into from
Mar 31, 2026
Merged

test: Cover IfStmt float condition and VariableDeclaration zero-init paths #236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
3866efd
test(#38): cover IfStmt float condition and VariableDeclaration zero-…
Jaskirat-s7 Mar 13, 2026
a809fd7
fix: add missing Type import in test_variable_assignment.py
Jaskirat-s7 Mar 17, 2026
357c5b2
test(#38): add Float64 to IfStmt parametrize list per review feedback
Jaskirat-s7 Mar 18, 2026
0db9c57
Fix commented-out test case in variable assignment test
yuvimittal Mar 19, 2026
bb3aa82
Fix comment formatting in test_variable_assignment.py
yuvimittal Mar 19, 2026
718fcb0
test(#38): add Float32/Float64 to test_variable_assignment per review
Jaskirat-s7 Mar 19, 2026
259a892
test(#38): assert zero-default output in test_variable_declaration_no…
Jaskirat-s7 Mar 19, 2026
db6c434
test(#38): expand test_variable_declaration_no_initializer per review
Jaskirat-s7 Mar 19, 2026
38fb079
ci: re-run jobs
Jaskirat-s7 Mar 19, 2026
65e3dfa
fix small issues
xmnlab Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/irx/builders/llvmliteir.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3552,7 +3552,9 @@ def visit(self, node: astx.VariableDeclaration) -> None:
type_str = node.type_.__class__.__name__.lower()

# Emit the initializer
if node.value is not None:
if node.value is not None and not isinstance(
node.value, astx.Undefined
):
self.visit(node.value)
init_val = self.result_stack.pop()
if init_val is None:
Expand Down
21 changes: 15 additions & 6 deletions tests/test_if_stmt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@
(astx.Int16, astx.LiteralInt16),
(astx.Int8, astx.LiteralInt8),
(astx.Int64, astx.LiteralInt64),
(astx.Float32, astx.LiteralFloat32),
Copy link
Copy Markdown
Member

@yuvimittal yuvimittal Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets add float64 as well?

Copy link
Copy Markdown
Contributor Author

@Jaskirat-s7 Jaskirat-s7 Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! Added (astx.Float64, astx.LiteralFloat64) to both test_if_else_stmt and test_if_only_stmt parametrize lists.

(astx.Float64, astx.LiteralFloat64),
],
)
@pytest.mark.parametrize(
Expand Down Expand Up @@ -75,17 +77,19 @@ def test_if_else_stmt(
if_stmt = astx.IfStmt(condition=cond, then=then_block, else_=else_block)

main_proto = astx.FunctionPrototype(
"main", args=astx.Arguments(), return_type=int_type()
"main", args=astx.Arguments(), return_type=astx.Int32()
)
main_body = astx.Block()
main_body.append(init_a)
main_body.append(if_stmt)
main_body.append(astx.FunctionReturn(literal_type(0)))
main_body.append(astx.FunctionReturn(astx.LiteralInt32(0)))

main_fn = astx.FunctionDef(prototype=main_proto, body=main_body)
module.block.append(main_fn)

check_result(action, builder, module, expected_file)
check_result(
action, builder, module, expected_file, expected_output="then branch"
)


@pytest.mark.parametrize(
Expand All @@ -94,6 +98,8 @@ def test_if_else_stmt(
(astx.Int32, astx.LiteralInt32),
(astx.Int16, astx.LiteralInt16),
(astx.Int8, astx.LiteralInt8),
(astx.Float32, astx.LiteralFloat32),
(astx.Float64, astx.LiteralFloat64),
],
)
@pytest.mark.parametrize(
Expand Down Expand Up @@ -146,17 +152,20 @@ def test_if_only_stmt(
if_stmt = astx.IfStmt(condition=cond, then=then_block)

main_proto = astx.FunctionPrototype(
"main", args=astx.Arguments(), return_type=int_type()
"main", args=astx.Arguments(), return_type=astx.Int32()
)
main_body = astx.Block()
main_body.append(init_a)
main_body.append(if_stmt)
main_body.append(astx.FunctionReturn(literal_type(0)))
main_body.append(PrintExpr(astx.LiteralUTF8String("done")))
main_body.append(astx.FunctionReturn(astx.LiteralInt32(0)))

main_fn = astx.FunctionDef(prototype=main_proto, body=main_body)
module.block.append(main_fn)

check_result(action, builder, module, expected_file)
check_result(
action, builder, module, expected_file, expected_output="done"
)


@pytest.mark.parametrize("builder_class", [LLVMLiteIR])
Expand Down
80 changes: 67 additions & 13 deletions tests/test_variable_assignment.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,62 +7,116 @@

from irx.builders.base import Builder
from irx.builders.llvmliteir import LLVMLiteIR
from irx.system import PrintExpr

from .conftest import check_result


@pytest.mark.parametrize(
"int_type, literal_type",
"var_type, literal_type, expected_output",
[
(astx.Int32, astx.LiteralInt32),
(astx.Int16, astx.LiteralInt16),
(astx.Int8, astx.LiteralInt8),
(astx.Int64, astx.LiteralInt64),
(astx.Int32, astx.LiteralInt32, "42"),
(astx.Int16, astx.LiteralInt16, "42"),
(astx.Int8, astx.LiteralInt8, "42"),
(astx.Int64, astx.LiteralInt64, "42"),
(astx.Float32, astx.LiteralFloat32, "42.000000"),
(astx.Float64, astx.LiteralFloat64, "42.000000"),
],
)
@pytest.mark.parametrize(
"builder_class",
[
# ("translate", "test_variable_assignment.ll"),
LLVMLiteIR,
],
)
def test_variable_assignment(
builder_class: type[Builder],
int_type: type,
var_type: type,
literal_type: type,
expected_output: str,
) -> None:
"""
title: Test VariableAssignment by reassigning and returning.
title: Test VariableAssignment by reassigning and printing.
parameters:
builder_class:
type: type[Builder]
int_type:
var_type:
type: type
literal_type:
type: type
expected_output:
type: str
"""
builder = builder_class()
module = builder.module()

decl = astx.InlineVariableDeclaration(
name="x",
type_=int_type(),
type_=var_type(),
value=literal_type(10),
mutability=astx.MutabilityKind.mutable,
)
assignment = astx.VariableAssignment(name="x", value=literal_type(42))

proto = astx.FunctionPrototype(
name="main", args=astx.Arguments(), return_type=int_type()
name="main", args=astx.Arguments(), return_type=astx.Int32()
)
fn_block = astx.Block()
fn_block.append(decl)
fn_block.append(assignment)
fn_block.append(astx.FunctionReturn(astx.Identifier("x")))
fn_block.append(PrintExpr(astx.Identifier("x")))
fn_block.append(astx.FunctionReturn(astx.LiteralInt32(0)))
fn_main = astx.FunctionDef(prototype=proto, body=fn_block)

module.block.append(fn_main)

check_result("build", builder, module, expected_output=expected_output)


@pytest.mark.parametrize(
"var_type, expected_output",
[
(astx.Int8, "0"),
(astx.Int16, "0"),
(astx.Int32, "0"),
(astx.Int64, "0"),
(astx.Float32, "0.000000"),
(astx.Float64, "0.000000"),
],
)
@pytest.mark.parametrize("builder_class", [LLVMLiteIR])
def test_variable_declaration_no_initializer(
builder_class: type[Builder],
var_type: type,
expected_output: str,
) -> None:
"""
title: Test VariableDeclaration without an initializer defaults to zero.
parameters:
builder_class:
type: type[Builder]
var_type:
type: type
expected_output:
type: str
"""
builder = builder_class()
module = builder.module()

decl = astx.VariableDeclaration(
name="x",
type_=var_type(),
)

proto = astx.FunctionPrototype(
name="main", args=astx.Arguments(), return_type=astx.Int32()
)
fn_block = astx.Block()
fn_block.append(decl)
fn_block.append(PrintExpr(astx.Identifier("x")))
fn_block.append(astx.FunctionReturn(astx.LiteralInt32(0)))
fn_main = astx.FunctionDef(prototype=proto, body=fn_block)

module.block.append(fn_main)

expected_output = "42"
check_result("build", builder, module, expected_output=expected_output)
Loading