Fix #445: restore Kitty keyboard protocol during attach for Shift+Enter#446
Draft
asheshgoplani wants to merge 1 commit intomainfrom
Draft
Fix #445: restore Kitty keyboard protocol during attach for Shift+Enter#446asheshgoplani wants to merge 1 commit intomainfrom
asheshgoplani wants to merge 1 commit intomainfrom
Conversation
…Enter (#445) The TUI disables the Kitty keyboard protocol at startup so Bubble Tea can parse key input. When attaching to a tmux session, this legacy mode persisted, preventing terminals from sending extended key sequences like Shift+Enter (CSI u encoding). Restore the protocol before attach and re-disable it on detach for all four attach paths (local, window, remote create+attach, remote attach). Fixes #445 Committed by Ashesh Goplani
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DisableKittyKeyboardis called at TUI startup for Bubble Tea compatibility, but was never restored when attaching to tmux sessions, leaving the terminal in legacy keyboard modeRestoreKittyKeyboard/DisableKittyKeyboardtoggle around all 4 attach paths (local, window, remote create+attach, remote attach)Test plan
go buildpassesgo vetpassesgo fmtcleanmake ci(pre-push hook)Fixes #445