Skip to content

Fix #445: restore Kitty keyboard protocol during attach for Shift+Enter #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
asheshgoplani wants to merge 1 commit into
base: main
Choose a base branch
from
+15 −0
Draft

Fix #445: restore Kitty keyboard protocol during attach for Shift+Enter #446

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions internal/ui/home.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7081,6 +7081,12 @@ func (a attachCmd) Run() error {
// NOTE: Screen clearing is ONLY done in the tea.Exec callback (after Attach returns)
// Removing clear screen here prevents double-clearing which corrupts terminal state

// Restore Kitty keyboard protocol so the outer terminal sends extended key
// sequences (Shift+Enter, etc.) through to the tmux session. The TUI disables
// the protocol at startup for Bubble Tea compatibility; re-disable on return.
RestoreKittyKeyboard(os.Stdout)
defer DisableKittyKeyboard(os.Stdout)

ctx := context.Background()
return a.session.Attach(ctx, a.detachByte)
}
Expand Down Expand Up @@ -7120,6 +7126,9 @@ type remoteCreateAndAttachCmd struct {
}

func (r remoteCreateAndAttachCmd) Run() error {
RestoreKittyKeyboard(os.Stdout)
defer DisableKittyKeyboard(os.Stdout)

ctx := context.Background()
sessionID, err := r.runner.CreateSession(ctx)
if err != nil {
Expand All @@ -7140,6 +7149,9 @@ type attachWindowCmd struct {
}

func (a attachWindowCmd) Run() error {
RestoreKittyKeyboard(os.Stdout)
defer DisableKittyKeyboard(os.Stdout)

ctx := context.Background()
return a.session.AttachWindow(ctx, a.windowIndex, a.detachByte)
}
Expand Down Expand Up @@ -7173,6 +7185,9 @@ type remoteAttachCmd struct {
}

func (r remoteAttachCmd) Run() error {
RestoreKittyKeyboard(os.Stdout)
defer DisableKittyKeyboard(os.Stdout)

return r.runner.Attach(r.sessionID)
}

Expand Down