adding buffer size as parameter.#21
Open
lorenzoromagnoli wants to merge 5 commits intoashishbajaj99:masterfrom
Open
adding buffer size as parameter.#21lorenzoromagnoli wants to merge 5 commits intoashishbajaj99:masterfrom
lorenzoromagnoli wants to merge 5 commits intoashishbajaj99:masterfrom
Conversation
ashishbajaj99
requested changes
Mar 8, 2019
Owner
ashishbajaj99
left a comment
ashishbajaj99
left a comment
There was a problem hiding this comment.
thank you for the PR. Kindly fix the indentation and then we are good to go.
| var exitOnSilence = options.exitOnSilence || 0; | ||
| var fileType = options.fileType || 'raw'; | ||
| var debug = options.debug || false; | ||
| var buffer = options.buffer || 500; |
Owner
There was a problem hiding this comment.
can you please fix the indentation?
| '-t', fileType, '--buffer', buffer , '-'], audioProcessOptions) | ||
| } | ||
| else { | ||
| var buffer_time=(buffer/rate)*1000000; |
| format, '-D', device], audioProcessOptions); | ||
| format, '-D', device, '--buffer-time', buffer_time], audioProcessOptions); | ||
| } | ||
| if(debug)console.log(audioProcess); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I needed to control the size of the recording buffer to be able to quickly process a fft on the signal.
Thank you very much for this package btw 👍