Skip to content

adding buffer size as parameter. #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lorenzoromagnoli wants to merge 5 commits into
base: master
Choose a base branch
from
Open

adding buffer size as parameter. #21

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8ad7472
adding buffer size as parameters to improve performances on realtime …
lorenzoromagnoli Sep 25, 2017
39a01a1
fixed typo
lorenzoromagnoli Sep 25, 2017
0cfda06
changed the way buffer is calculated on linux
lorenzoromagnoli Sep 25, 2017
9948d03
conversion to microsecond
lorenzoromagnoli Sep 25, 2017
28758fc
better formula to calculare buffer size
lorenzoromagnoli Sep 25, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions lib/mic.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ var mic = function mic(options) {
var exitOnSilence = options.exitOnSilence || 0;
var fileType = options.fileType || 'raw';
var debug = options.debug || false;
var buffer = options.buffer || 500;
Copy link
Owner

@ashishbajaj99 ashishbajaj99 Mar 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please fix the indentation?

var format, formatEndian, formatEncoding;
var audioProcess = null;
var infoStream = new PassThrough;
Expand Down Expand Up @@ -47,18 +48,20 @@ var mic = function mic(options) {
if(isWindows){
audioProcess = spawn('sox', ['-b', bitwidth, '--endian', endian,
'-c', channels, '-r', rate, '-e', encoding,
'-t', 'waveaudio', 'default', '-p'],
'-t', '--buffer', buffer , 'waveaudio', 'default', '-p'],
audioProcessOptions)
}
else if(isMac){
audioProcess = spawn('rec', ['-b', bitwidth, '--endian', endian,
'-c', channels, '-r', rate, '-e', encoding,
'-t', fileType, '-'], audioProcessOptions)
'-t', fileType, '--buffer', buffer , '-'], audioProcessOptions)
}
else {
var buffer_time=(buffer/rate)*1000000;
Copy link
Owner

@ashishbajaj99 ashishbajaj99 Mar 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix the indentation

audioProcess = spawn('arecord', ['-c', channels, '-r', rate, '-f',
format, '-D', device], audioProcessOptions);
format, '-D', device, '--buffer-time', buffer_time], audioProcessOptions);
}
if(debug)console.log(audioProcess);
Copy link
Owner

@ashishbajaj99 ashishbajaj99 Mar 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix the indentation


audioProcess.on('exit', function(code, sig) {
if(code != null && sig === null) {
Expand Down