fix(mcp): add query→sql backward compat alias in query_asset_tool#216
Open
mothership-ai[bot] wants to merge 1 commit intomainfrom
Open
fix(mcp): add query→sql backward compat alias in query_asset_tool#216mothership-ai[bot] wants to merge 1 commit intomainfrom
mothership-ai[bot] wants to merge 1 commit intomainfrom
Conversation
LLM clients still send `query` (old param name) instead of `sql`, causing ~8 errors/30d. Accept `query` as a deprecated alias. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Session owner: @
Summary
queryas a deprecated alias parameter toquery_asset_toolfor backward compatibilityquery(the old param name) instead ofsql, causing ~8 errors/30d (Unexpected keyword argument: query)queryis provided butsqlis not,queryis used assqltransparentlyChanges
modelcontextprotocol/server.py: Added optionalqueryparam toquery_asset_tool, with alias logic at function entry point and explicit validation when neither param is providedTest plan
query_asset_tool(query="SELECT 1", connection_qualified_name="...")→ should work (backward compat)query_asset_tool(sql="SELECT 1", connection_qualified_name="...")→ should work (current behavior)query_asset_tool(connection_qualified_name="...")with neither sql nor query → should return errorsqlandquery→sqltakes precedenceCloses AICHAT-833
🤖 Generated with Claude Code