Skip to content

fix(mcp): add query→sql backward compat alias in query_asset_tool #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mothership-ai wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(mcp): add query→sql backward compat alias in query_asset_tool #216

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion modelcontextprotocol/server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -655,7 +655,10 @@ def update_assets_tool(

@mcp.tool()
def query_asset_tool(
sql: str, connection_qualified_name: str, default_schema: str | None = None
sql: str | None = None,
connection_qualified_name: str = "",
default_schema: str | None = None,
query: str | None = None,
):
"""
Execute a SQL query on a table/view asset.
Expand All @@ -678,6 +681,7 @@ def query_asset_tool(
default_schema (str, optional): Default schema name to use for unqualified
objects in the SQL, in the form "DB.SCHEMA"
(e.g., "RAW.WIDEWORLDIMPORTERS_WAREHOUSE")
query (str, optional): Deprecated alias for 'sql'. Use 'sql' instead.

Examples:
# Use case: How to query the PAGES table and retrieve the first 10 rows
Expand Down Expand Up @@ -722,6 +726,18 @@ def query_asset_tool(
default_schema="LANDING.FRONTEND_PROD"
)
"""
# Backward compat: accept deprecated 'query' param as alias for 'sql'
if query and not sql:
sql = query

if not sql:
return {
"success": False,
"data": None,
"error": "Either 'sql' or 'query' parameter must be provided",
"query_info": {},
}

return query_asset(sql, connection_qualified_name, default_schema)


Expand Down
Loading