feat(domain-server): allow PVCs for Deployment kind too#27
Merged
dataviruset merged 4 commits intomainfrom Dec 19, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR consolidates the Helm chart templates to support both Deployment and StatefulSet workload types with a unified template. The main purpose is to enable PersistentVolumeClaims (PVCs) for Deployment kind workloads, which were previously only available for StatefulSets.
Key Changes:
- Merged deployment.yaml and StatefulSet-specific workload.yaml into a single workload.yaml template that dynamically handles both workload types
- Added conditional logic to set replicas for Deployments and serviceName for StatefulSets
- Updated the chart and app versions to 0.5.3 and 0.8 respectively
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| charts/domain-server/templates/workload.yaml | Modified to dynamically support both Deployment and StatefulSet kinds with conditional fields |
| charts/domain-server/templates/deployment.yaml | Deleted entirely as functionality merged into workload.yaml |
| charts/domain-server/Chart.yaml | Bumped chart version to 0.5.3 and app version to 0.8 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
Why do we want to allow PVC for deployment? replicas + PVCs will cause the data distributes in different PVCs, wont it? |
shuning-auki
approved these changes
Dec 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also bumps the app version to v0.8 as the domain-server v0.8.4 will be released very soon.