feat: migrate to job attachments package#1133
Open
epmog wants to merge 1 commit intoaws-deadline:mainlinefrom
Open
feat: migrate to job attachments package#1133epmog wants to merge 1 commit intoaws-deadline:mainlinefrom
epmog wants to merge 1 commit intoaws-deadline:mainlinefrom
Conversation
github-actions
Bot
added
the
waiting-on-maintainers
epmog
force-pushed
the
use_deadline_job_attachments
branch
4 times, most recently
from
09d0c88 to
48aaf98
Compare
Signed-off-by: Morgan Epp <60796713+epmog@users.noreply.github.com>
epmog
force-pushed
the
use_deadline_job_attachments
branch
from
48aaf98 to
ee3c415
Compare
diane-hj
approved these changes
Apr 24, 2026
leongdl
approved these changes
Apr 24, 2026
godobyte
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
job-attachments has moved to its own repo and pypi package:
and deadline-cloud needs to be updated to consume the new library.
What was the solution? (How)
Perform the second part of the migration, which is delete all the previous job attachments specific code from this repo
What is the impact of this change?
Should be invisible to users, but now we have a dedicated library with its own version/release cycle.
How was this change tested?
Was this change documented?
The github website now pulls job attachments docs from the new job attachments repo.
So now we can delete those docs from this repo
Does this PR introduce new dependencies?
It does, but it's ours :)
Is this a breaking change?
No, because the job attachments library maintained the same interface. It's the same code, just in a new spot.
Does this change impact security?
N/A
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.