Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .github/CODEOWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,3 @@
* @aws-deadline/deadline-cloud-developers

# https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners
# overriding directories for job attachments
src/deadline/job_attachments/ @aws-deadline/job-attachments-developers
test/*/deadline_job_attachments/ @aws-deadline/job-attachments-developers
2 changes: 0 additions & 2 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@ See [DEVELOPMENT.md](https://github.com/aws-deadline/deadline-cloud/blob/mainlin

- Have you run the unit tests?
- Have you run the integration tests?
- Have you made changes to the `download` or `asset_sync` modules? If so, then it is highly recommended
that you ensure that the docker-based unit tests pass.

### Was this change documented?

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/code_quality.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ jobs:
python-version: ${{ matrix.python-version }}
ref: ${{inputs.tag}}
# The incremental output download and mcp feature doesn't run on Python 3.8, so test coverage is lower
cov-fail-under: "74"
cov-fail-under: "63"

Attributions:
name: Attributions
Expand Down
4 changes: 0 additions & 4 deletions AGENTS.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,6 @@ src/deadline/
│ ├── ui/ # Qt/PySide GUI components
│ ├── job_bundle/ # Job bundle handling and history
│ └── dataclasses/ # Data structures
├── job_attachments/ # File transfer to/from S3
│ ├── api/ # Public job attachments API
│ ├── caches/ # Hash and S3 check caches
│ └── asset_manifests/ # Manifest handling
├── mcp/ # MCP server (public)
├── _mcp/ # MCP server (internal)
└── common/ # Shared utilities
Expand Down
5 changes: 2 additions & 3 deletions docs/code_reference/code_organization.md
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
# Code organization

This repository is split up into two main modules:
1. `src/client`
2. `src/job_attachments`
The main module in this repository is `src/client`. Job attachments functionality
lives in the separate [`deadline-cloud-job-attachments`](https://github.com/aws-deadline/deadline-cloud-job-attachments) package.

The `src/client` organization is laid out below.

Expand Down
1 change: 0 additions & 1 deletion docs/code_reference/job_attachments_api.md

This file was deleted.

1 change: 0 additions & 1 deletion docs/code_reference/job_attachments_asset_manifests.md

This file was deleted.

1 change: 0 additions & 1 deletion docs/code_reference/job_attachments_asset_sync.md

This file was deleted.

1 change: 0 additions & 1 deletion docs/code_reference/job_attachments_caches.md

This file was deleted.

1 change: 0 additions & 1 deletion docs/code_reference/job_attachments_download.md

This file was deleted.

1 change: 0 additions & 1 deletion docs/code_reference/job_attachments_exceptions.md

This file was deleted.

1 change: 0 additions & 1 deletion docs/code_reference/job_attachments_models.md

This file was deleted.

This file was deleted.

1 change: 0 additions & 1 deletion docs/code_reference/job_attachments_progress_tracker.md

This file was deleted.

1 change: 0 additions & 1 deletion docs/code_reference/job_attachments_upload.md

This file was deleted.

1 change: 0 additions & 1 deletion docs/code_reference/job_attachments_vfs.md

This file was deleted.

24 changes: 12 additions & 12 deletions docs/design/storage-profile-cli-support.md
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ _incremental_output_download()

### 4.4 Path Mapping Implementation

**File:** `src/deadline/job_attachments/_path_mapping.py`
**File:** `deadline-cloud-job-attachments/src/deadline/job_attachments/_path_mapping.py`

#### 4.4.1 Rule Generation

Expand Down Expand Up @@ -225,7 +225,7 @@ class _PathMappingRuleApplier:

### 4.5 Download File Operations

**File:** `src/deadline/job_attachments/download.py`
**File:** `deadline-cloud-job-attachments/src/deadline/job_attachments/download.py`

#### 4.5.1 OutputDownloader Class

Expand Down Expand Up @@ -268,7 +268,7 @@ def download_files(

### 5.1 StorageProfile

**File:** `src/deadline/job_attachments/models.py`
**File:** `deadline-cloud-job-attachments/src/deadline/job_attachments/models.py`

```python
@dataclass
Expand All @@ -281,7 +281,7 @@ class StorageProfile:

### 5.2 FileSystemLocation

**File:** `src/deadline/job_attachments/models.py`
**File:** `deadline-cloud-job-attachments/src/deadline/job_attachments/models.py`

```python
@dataclass
Expand Down Expand Up @@ -520,7 +520,7 @@ Note: Both profiles are fetched via the typed API (`api.get_storage_profile_for_

Since the function is private (underscore-prefixed) with only two call sites (`_incremental_download.py` and the new `_job_download_helpers.py`), we refactor it directly instead of adding an adapter.

**File:** `src/deadline/job_attachments/_path_mapping.py`
**File:** `deadline-cloud-job-attachments/src/deadline/job_attachments/_path_mapping.py`

```python
def _generate_path_mapping_rules(
Expand Down Expand Up @@ -827,12 +827,12 @@ Each helper function is independently testable in `test/unit/deadline_client/cli
| Incremental download | `src/deadline/client/cli/_incremental_download.py` |
| Job submission API | `src/deadline/client/api/_submit_job_bundle.py` |
| Storage profile API | `src/deadline/client/api/_get_storage_profile_for_queue.py` |
| S3AssetManager | `src/deadline/job_attachments/upload.py` |
| OutputDownloader | `src/deadline/job_attachments/download.py` |
| Path mapping | `src/deadline/job_attachments/_path_mapping.py` |
| Hash algorithms | `src/deadline/job_attachments/asset_manifests/hash_algorithms.py` |
| Hash cache | `src/deadline/job_attachments/caches/hash_cache.py` |
| Models | `src/deadline/job_attachments/models.py` |
| S3AssetManager | `deadline-cloud-job-attachments/src/deadline/job_attachments/upload.py` |
| OutputDownloader | `deadline-cloud-job-attachments/src/deadline/job_attachments/download.py` |
| Path mapping | `deadline-cloud-job-attachments/src/deadline/job_attachments/_path_mapping.py` |
| Hash algorithms | `deadline-cloud-job-attachments/src/deadline/job_attachments/asset_manifests/hash_algorithms.py` |
| Hash cache | `deadline-cloud-job-attachments/src/deadline/job_attachments/caches/hash_cache.py` |
| Models | `deadline-cloud-job-attachments/src/deadline/job_attachments/models.py` |
| Config file | `src/deadline/client/config/config_file.py` |

---
Expand Down Expand Up @@ -905,7 +905,7 @@ Key operations:

### 12.3 Asset Manager: `S3AssetManager`

**File:** `src/deadline/job_attachments/upload.py`
**File:** `deadline-cloud-job-attachments/src/deadline/job_attachments/upload.py`

```
S3AssetManager.__init__()
Expand Down
173 changes: 0 additions & 173 deletions docs/job_attachments_guide.md

This file was deleted.

1 change: 0 additions & 1 deletion examples/README.md

This file was deleted.

Loading
Loading