added the implementation to centralize the tools IAM permissions#6
Open
jshashankaws wants to merge 3 commits intoaws-samples:mainfrom
Open
added the implementation to centralize the tools IAM permissions#6jshashankaws wants to merge 3 commits intoaws-samples:mainfrom
jshashankaws wants to merge 3 commits intoaws-samples:mainfrom
Conversation
… gateway interceptor
ujwalbukka
reviewed
Apr 7, 2026
cdk/lib/agentcore-stack.ts
Outdated
| }, | ||
| }, | ||
| }, | ||
| ]; |
Contributor
There was a problem hiding this comment.
Since interceptor role is assuming the role, I don't think we need above trust statement attached to LogMCPHandler tool/lambda role
Author
There was a problem hiding this comment.
updated to remove this trust statement for basic role.
ujwalbukka
reviewed
Apr 7, 2026
cdk/lib/agentcore-stack.ts
Outdated
Contributor
There was a problem hiding this comment.
Do we need this policy now in this role? as LogMcpHandler won't be assuming any role.
Author
There was a problem hiding this comment.
updated to remove this trust statement for basic role.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added the implementation to centralize the tools IAM permissions from gateway interceptor
Issue #, if available:
Tools managing the logic to assume IAM role permissions. However those required IAM permissions can also be centralized through gateway interceptor.
Description of changes:
This PR contains changes to support centralize the tools IAM permissions from gateway interceptor
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.