Conversation
Summary of ChangesHello @axeldelafosse, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request streamlines the patch release process by introducing a new Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds a release:patch script to simplify patch releases. The change is good, but the script can be made more robust. I've suggested making the git push command more explicit to ensure it always pushes to the main branch, as intended for releases. This will prevent accidental releases from other branches.
| "scripts": { | ||
| "build": "bun build --compile --outfile loop src/loop.ts", | ||
| "install:global": "bun run build && bun run src/install.ts", | ||
| "release:patch": "npm version patch && git push --follow-tags", |
There was a problem hiding this comment.
The git push command in this script doesn't specify a branch. It will push the current branch, which may not be main. According to your README.md, releases are triggered by pushes to main. To make the release process more robust and prevent accidental releases from other branches, I recommend explicitly pushing to origin main.
With this change, you'll also want to update the comment in README.md on line 117 to # npm version patch && git push origin main --follow-tags to keep the documentation accurate.
| "release:patch": "npm version patch && git push --follow-tags", | |
| "release:patch": "npm version patch && git push origin main --follow-tags", |
Summary
release:patchscript topackage.json:npm version patch && git push --follow-tagsREADME.mdto document patch release using the new script:bun run release:patchWhy
Files Changed
package.jsonREADME.mdTesting