Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -110,12 +110,11 @@ source ~/.zshrc
Example release:

```bash
# bump version
npm version patch
# bump patch version and push commit + tag
bun run release:patch

# push commit + tag created by npm version
git push origin main
git push --tags
# equivalent to:
# npm version patch && git push --follow-tags
```

## Auto-update
Expand Down
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
"scripts": {
"build": "bun build --compile --outfile loop src/loop.ts",
"install:global": "bun run build && bun run src/install.ts",
"release:patch": "npm version patch && git push --follow-tags",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The git push command in this script doesn't specify a branch. It will push the current branch, which may not be main. According to your README.md, releases are triggered by pushes to main. To make the release process more robust and prevent accidental releases from other branches, I recommend explicitly pushing to origin main.

With this change, you'll also want to update the comment in README.md on line 117 to # npm version patch && git push origin main --follow-tags to keep the documentation accurate.

Suggested change
"release:patch": "npm version patch && git push --follow-tags",
"release:patch": "npm version patch && git push origin main --follow-tags",

"check": "ultracite check",
"fix": "ultracite fix"
},
Expand Down