Add admin-area1 to formatting rules for DE, FR, NL and PL and perform accompanying cleanups #84
Add admin-area1 to formatting rules for DE, FR, NL and PL and perform accompanying cleanups #84
Conversation
These updates are coming from several recent changes including at least: * splitting postal code, * adding Japan model, * adding admin-area1 to formatting rules for European countries.
| - street-address-alternative-1 | ||
| - separator: "\n" | ||
| - locality1 | ||
| - separator: " " |
There was a problem hiding this comment.
What's the reasoning behind removing these separators?
There was a problem hiding this comment.
When separator is absent, " " value is getting assigned.
I removed it to achieve consistency between files - i.e. to not specify the default value explicitly.
This is no-op in the generated files, which is easiest to verify by looking at them directly.
| @@ -1,5 +1,10 @@ | |||
| formatting-rules: | |||
| address: | |||
| # {street-address-alternative-1} | |||
There was a problem hiding this comment.
This made it easier for me to understand how the formatting works across the files.
This brings consistency across files (before there were some comments with some formats in some files, now there is 1 comment with specific format in each file).
I extracted these cleanup changes into a separate commit. Please let me know if you believe they trash this PR and they should be moved into a separate PR instead.
This reverts commit 8b5cb33.
|
Looks fine to me (though honestly I'd prob prefer more if there was a separate PR with all of the comments/removing default separator changes). Let's add Norge to take a look before landing this |
|
Also please add in the PR description why more countries have changes to their .html files (what we discussed offline) |
norgevz
left a comment
norgevz
left a comment
There was a problem hiding this comment.
Could you please divide this PR into two different ones containing:
- Generated files related to previous PRs.
- Files related to the changes listed in the PR title.
Created #85 for 1. |
|
I'm closing this pull request and replacing it with another PRs
|
3 participants
It is added as a separate line, just before the country-name, for each of the 4 affected locales.
This is a big step to ensure information growth invariant holds for all the locales.
Also update the HTML docs files, as generated. updates are coming from other recent PRs that didn't include their coresponding changes, including at least:
Next steps (not included in this PR) include:
resolving country vs country_name inconsistency between hierarchy and formatting rules
converge formatting rules, parsing rules and transpile rules to build the same forest structure.