Fix area1 formatting rules for DE, FR, NL and PL by oroko123 · Pull Request #87 · battre/autocomplete-attribute-explainer

oroko123 · 2026-01-21T16:33:24Z

This is a changed version of #84
This also performs accompanying cleanups and updates the generated HTML files.

…sistency

norgevz · 2026-01-26T13:53:00Z

model/countries/IN/IN-formatting-rules.yaml

@@ -1,5 +1,12 @@
 formatting-rules:
  address:
+  # {building-location}


Please remove these sort of comments. They aren't adding much.

They are very helpful for my understanding.
Are they hurting your understanding? Otherwise I'd keep.

Yes, it's not at all clear to me what they are adding. Let's remove them.

norgevz · 2026-01-26T13:53:49Z

model/countries/AU/AU-formatting-rules.yaml

    - street-address-alternative-1
    - separator: "\n"
    - locality1
-    - separator: " "


Why are these separator dropped?

This is more of a cosmetic change.
Since the "single space" separator is default, I think we should consistently use it or not use it (it differed between files before)

(Also the generated cpp files have no diff).

I think even if a single space is the default separator I believe they add clarity. Let's keep them.

Sounds good.
I'll create a separate PR that adds single spaces where needed so that we have a consistent behavior (single spaces everywhere; default not used)

Actually I agree that they add clarity. Let me add them everywhere here already (since the discussion is happening in this PR)

norgevz · 2026-01-26T13:54:32Z

model/countries/CA/CA-formatting-rules.yaml

  - separator: "\n"
  - country-name
  - skip: country  # redundant with country-name
-  - skip: street-address  # redundant with street-address-alternative-1


Why is this dropped?

this is dropped, since it's confusing and pointless. We shouldn't skip the field that is included.

Are you certain that street-address is not generated if it is not explicitly skipped? IIRC, that was the main reason why these skip rules were included.

this is needed for other locales, where there is a country-specific model that includes street-address-alternative-1. There we need to skip street-address not to have 2 nodes that represent ADDRESS_HOME_STREET_ADDRESS.
For Canada (and the US for example) we use street-address.
I guess what happens when street-address is both listed and skipped is an undefined behavior, and that just happens to be no op, but it's extremely confusing.

Both street-address and street-address-alternative-1 map to ADDRESS_HOME_STREET_ADDRESS. If US and CA are both using street-address, shouldn't we then skip street-address-alternative-1? Otherwise IIUC we will be generating ADDRESS_HOME_STREET_ADDRESS twice for US and CA.

We don't have to skip it in the formatting rules, the child (street-address-alternative-1) is already cut-off in the CA-model.yaml and US-model.yaml.
We theoretically can add the "skip street-address-alternative-1" but it's not needed.
I compared the generated c++ files and adding/removing this skip is no-op

Thanks for checking. Let's add then skip street-address-alternative-1 for consistency and we should be good to go.

ahh sorry for the fake info ;)
I tried this last week and I forgot the outcome.
Actually adding this skip didn't work:
error message:
"
Formatting errors for address: ["'skip street-address-alternative-1' exists in the rule but is not a descendant of 'address' in the model."]
address: [street-address: [address-line1, address-line2, address-line3, address-line4], locality1, admin-area1, postal-code: [postal-code-prefix, postal-code-suffix], country, country-name]
"
this is expected per my previous comment.

norgevz · 2026-01-26T13:54:50Z

model/countries/DE/DE-formatting-rules.yaml

  - street-address-alternative-1
  - separator: "\n"
  - postal-code
-  - separator: " "


Why is this separator dropped? Similar question on the files below.

This was autogenerated after changed introduced by battre/autocomplete-attribute-explainer#87. This adds ADDRESS_HOME_STATE (Land, Région, provincies, województwo) to parsing rules for these countries as a separate line on top of country. After this change all the countries' admin-area1 are includes in proper formatting rules. This brings us closer to achieve growth invariant Bug: 450838894 Change-Id: I187d4c3f81d079239e3e605c8faf81d40e7d11cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7474650 Commit-Queue: Przemek Perkowski <perkowski@google.com> Reviewed-by: Norge Vizcay <vizcay@google.com> Reviewed-by: Karol Sygiet <sygiet@google.com> Cr-Commit-Position: refs/heads/main@{#1580711}

oroko123 added 4 commits January 21, 2026 16:22

Add admin-area1 to formatting rules for DE, FR, NL and PL

e647ad7

Cleanup the comments in formatting rules of all the countries for con…

401737e

…sistency

Update per-country .html files in docs/model.

e6f4861

Revert the file formatting change in BR

137a8a6

oroko123 requested review from norgevz and skyman503 January 21, 2026 16:33

oroko123 mentioned this pull request Jan 21, 2026

Add admin-area1 to formatting rules for DE, FR, NL and PL and perform accompanying cleanups #84

Closed

skyman503 approved these changes Jan 22, 2026

View reviewed changes

norgevz reviewed Jan 26, 2026

View reviewed changes

oroko123 requested a review from norgevz January 26, 2026 14:04

oroko123 added 3 commits January 27, 2026 16:01

Delete useless comments in the formatting rules yaml files

393f61d

Add default space separators

3d9e638

Update the html files to match the empty delimeter

53e8bd0

norgevz approved these changes Jan 29, 2026

View reviewed changes

oroko123 merged commit 4d837d6 into main Jan 29, 2026
2 checks passed

Conversation

oroko123 commented Jan 21, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

oroko123 Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

oroko123 Jan 28, 2026 •

edited

Loading