-
Notifications
You must be signed in to change notification settings - Fork 151
Enable support for AEGs #1585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Enable support for AEGs #1585
Conversation
(cherry picked from commit 8a4310e) Signed-off-by: Brentley Jones <github@brentleyjones.com>
af07b00
to
59bbd80
Compare
We will need to apply bazelbuild/rules_apple@3da7b31 in rules_apple before landing this. as well as some other toolchains/AEG stuff in general. |
Current failures are unrelated to PR, but I don't feel safe merging this while they are there. |
Also looks like we need to set toolchains for the proto stuff. Upstream defines |
@brentleyjones I'm not familiar with Automatic Extension Groups but you're welcome to modify the swift_proto_library rule to support them. However, longer term I was thinking it would be more maintainable to refactor them into a macro with a source-generating rule which passes the generated sources into a regular swift_library. This is the approach I took at Snap for our new Swift dependency injection system and it has been working well for us so far. There are a couple of tradeoffs to this approach, though, and it would be a source-breaking change so we would have to retain the old behavior with some kind of legacy_mode flag. |
Ignore the AEGs portion, I was more calling out the toolchain-ification of the proto rules in |
(cherry picked from commit 8a4310e)