Skip to content

Enable support for AEGs #1585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Enable support for AEGs #1585

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 3 additions & 10 deletions swift/swift_binary.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@

"""Implementation of the `swift_binary` rule."""

load("@bazel_skylib//lib:dicts.bzl", "dicts")
load("@bazel_skylib//lib:paths.bzl", "paths")
load("@rules_cc//cc/common:cc_common.bzl", "cc_common")
load("@rules_cc//cc/common:cc_info.bzl", "CcInfo")
Expand Down Expand Up @@ -276,15 +275,9 @@ def _swift_binary_impl(ctx):
return providers

swift_binary = rule(
attrs = dicts.add(
binary_rule_attrs(
additional_deps_providers = [[SwiftCompilerPluginInfo]],
stamp_default = -1,
),
{
# TODO(b/301253335): Enable AEGs and switch from `swift` exec_group to swift `toolchain` param.
"_use_auto_exec_groups": attr.bool(default = False),
},
attrs = binary_rule_attrs(
additional_deps_providers = [[SwiftCompilerPluginInfo]],
stamp_default = -1,
),
doc = """\
Compiles and links Swift code into an executable binary.
Expand Down
2 changes: 0 additions & 2 deletions swift/swift_compiler_plugin.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,8 +371,6 @@ universal_swift_compiler_plugin = rule(
mandatory = True,
providers = [[SwiftBinaryInfo, SwiftCompilerPluginInfo]],
),
# TODO(b/301253335): Enable AEGs and switch from `swift` exec_group to swift `toolchain` param.
"_use_auto_exec_groups": attr.bool(default = False),
},
),
doc = """\
Expand Down
3 changes: 0 additions & 3 deletions swift/swift_library.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,9 +285,6 @@ dependent for linking, but artifacts/flags required for compilation (such as
.swiftmodule files, C headers, and search paths) will not be propagated.
""",
),
# TODO(b/301253335): Once AEGs are enabled in Bazel, set the swift toolchain type in the
# exec configuration of `plugins` attribute and enable AEGs in swift_library.
"_use_auto_exec_groups": attr.bool(default = False),
},
),
doc = """\
Expand Down
2 changes: 0 additions & 2 deletions swift/swift_test.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -604,8 +604,6 @@ environment when the test is executed by `bazel test`.
Label("//tools/test_observer"),
],
),
# TODO(b/301253335): Enable AEGs and switch from `swift` exec_group to swift `toolchain` param.
"_use_auto_exec_groups": attr.bool(default = False),
},
),
doc = """\
Expand Down
2 changes: 0 additions & 2 deletions swift/toolchains/xcode_swift_toolchain.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -993,8 +993,6 @@ for incremental compilation using a persistent mode.
fragment = "apple",
),
),
# TODO(b/301253335): Enable AEGs later.
"_use_auto_exec_groups": attr.bool(default = False),
},
),
doc = "Represents a Swift compiler toolchain provided by Xcode.",
Expand Down