31775 Add prop to disable ShareStructure buttons#299
Merged
severinbeauvais merged 4 commits intomainfrom Jan 30, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a disabled prop to the ShareStructure component to allow the parent to disable key share-structure action buttons (Add, Change, More Actions) when needed (eg, during higher-level workflows).
Changes:
- Introduced a new
disabledboolean prop onShareStructurewith a default offalse. - Updated the “Add Share Class”, “Change” (per-class edit), and “More Actions” dropdown activator buttons to be disabled when either
addEditInProgressis true or the newdisabledprop is true.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
severinbeauvais
commented
Jan 30, 2026
severinbeauvais
commented
Jan 30, 2026
| const vuetify = new Vuetify({}) | ||
| const localVue = createLocalVue() | ||
|
|
||
| const shareClassesOriginal: any = [ |
Collaborator
Author
There was a problem hiding this comment.
I simply moved these objects out of the describe block so that I could use them in another describe block.
severinbeauvais
commented
Jan 30, 2026
|
|
||
| wrapper.destroy() | ||
| }) | ||
| }) |
Collaborator
Author
There was a problem hiding this comment.
(I temporarily renamed the test class for this.)
severinbeauvais
force-pushed
the
31775
branch
from
7a86186 to
b52614f
Compare
added 2 commits
January 30, 2026 12:03
- updated Storybook
severinbeauvais
force-pushed
the
31775
branch
from
2c7e909 to
3d628aa
Compare
severinbeauvais
commented
Jan 30, 2026
Collaborator
Author
There was a problem hiding this comment.
Here's the ShareStructure Alteration story with disabled=True:
vysakh-menon-aot
approved these changes
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #: bcgov/entity#31775
You don't need to review any files in docs/. Those are generated Storybook files. Instead, you can checkout this PR and run
npm run storybook.Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).