Use u16 indices if possible in mesh primitives #21924
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Indices::U32uses more memory and it's unnecessary if vertex count <= 65536 (most case). But all mesh primitives useIndices::U32Solution
Use
Indices::U16if possible in mesh primitives.I added
Indices::with_capacity(),resize()andset()as helpers to create indices. Also addedglam_bytemuckand used it in Capsule3dMeshBuilder.Testing
Tested with the 2d_shapes and 3d_shapes examples.