Fix the doc test for WebAssetPlugin #21968
Open
+7
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andriyDev
added
D-Trivial
james7132
changed the title
kfc35
reviewed
Nov 29, 2025
| /// # impl Sprite { fn from_image(_: Handle<Image>) -> Self { Sprite } } | ||
| /// # fn main() { | ||
| /// App::new() | ||
| /// # .add_plugins((TaskPoolPlugin::default(), AssetPlugin::default())) |
Contributor
There was a problem hiding this comment.
There’s a comment on line 14 that says:
"/// NOTE: Make sure to add this plugin *before* AssetPlugin to properly register http asset sources.”
Does this line contradict that statement? The App is now adding WebAssetPlugin later than AssetPlugin if I’m interpreting this correctly
kfc35
reviewed
Nov 29, 2025
| /// # fn main() { | ||
| /// App::new() | ||
| /// # .add_plugins((TaskPoolPlugin::default(), AssetPlugin::default())) | ||
| /// # .init_asset::<Image>() |
Contributor
There was a problem hiding this comment.
I’d also assume you’d init the asset after adding the WebAssetPlugin… but I may be mistaken!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
cargo t -p bevy_asset --all-features.all-featuresdo not run on CI!WebAssetPlugindon't compile at all. There are bad imports and we don't even add theAssetPlugin.Solution
App.Testing
cargo t -p bevy_asset --all-featuresand it passes now!