Add a new almost_finish method for Timer with immediate first tick action
#21983
+37
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
action Resolves bevyengine#21860 This new method would tick the timer by `duration - 1 ns` leaving a very short waiting time for the first tick initiated by the user allowing immediate action.
Rajveer100
force-pushed
the
timer-almost_finish
branch
from
543f66c to
1382f97
Compare
alice-i-cecile
added
C-Usability
| } | ||
|
|
||
| /// Almost finishes the timer leaving 1 ns of remaining time. | ||
| /// |
Member
There was a problem hiding this comment.
Please add another line here explaining why this method would be useful.
| duration: Duration, | ||
| mode: TimerMode, | ||
| finished: bool, | ||
| almost_finished: bool, |
Member
There was a problem hiding this comment.
I don't think we need this field at all: simply setting the duration remaining to 1 ns should do the trick directly without adding complexity / wasted data.
alice-i-cecile
requested changes
Nov 30, 2025
Member
alice-i-cecile
left a comment
alice-i-cecile
left a comment
There was a problem hiding this comment.
I think we can + should get rid of the bool, but I like the 1 ns solution!
alice-i-cecile
added
S-Waiting-on-Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Resolves #21860
This new method would tick the timer by
duration - 1 nsleaving a very short waiting time for the first tick initiated by the user allowing immediate action.Solution
The
almost_finishmethod updates the timer by ticking it with1nsremaining.Testing
Tests have been added in
almost_finished_repeating.