Polygon area type for geofencing subscriptions#336
Draft
ilya-smirnov-berlin wants to merge 4 commits intocamaraproject:mainfrom
Draft
Conversation
ilya-smirnov-berlin
requested review from
bigludo7,
jlurien and
maxl2287
as code owners
Co-authored-by: Jose Luis Urien <jlurien@gmail.com>
alpaycetin74
approved these changes
Jun 27, 2025
Collaborator
alpaycetin74
left a comment
alpaycetin74
left a comment
There was a problem hiding this comment.
LGTM, let's double check with other reviewers. Thank you.
Collaborator
|
The PR looks OK. We have to decide in the next meeting if this is to be merged as part of Fall25 scope or keep it on hold for a future meta-release |
Collaborator
|
As we're still in a 0.x version I'm fine to introduce this feature for this Fall'25 release but not a blocker from me if the team prefers to wait next one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
Geofences should support polygon type areas. Circle as only type is rarely used for geofencig. Usually a geofence describes a shape of an (often human built) geographical object like factories, buildings, city and country areas.
Which issue(s) this PR fixes:
Fixes #194
Special notes for reviewers:
Polygon types for location verification will be done in separate PR
Changelog input