problem_report: fix file extension for zstd compressed values#575
Merged
bdrung merged 2 commits intocanonical:mainfrom Apr 24, 2026
Merged
problem_report: fix file extension for zstd compressed values#575bdrung merged 2 commits intocanonical:mainfrom
bdrung merged 2 commits intocanonical:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #575 +/- ##
==========================================
+ Coverage 84.47% 84.52% +0.05%
==========================================
Files 104 104
Lines 20926 20984 +58
Branches 3212 3217 +5
==========================================
+ Hits 17677 17737 +60
+ Misses 2808 2806 -2
Partials 441 441 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bdrung
force-pushed
the
zstd-compression
branch
3 times, most recently
from
40ce78f to
4a31139
Compare
Hyask
approved these changes
Apr 24, 2026
Contributor
Hyask
left a comment
Hyask
left a comment
There was a problem hiding this comment.
Thanks, that looks good to me.
Refactor `problem_report.py` by introducing the helper function `_create_compressed_attachment` in preparation for following commits. Ensure that the type of `attach_value` is either `None` or `bytes`. Bug: https://launchpad.net/bugs/2148656 Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
When Apport is used with systemd-coredump, the CoreDump is zstd compressed (instead of gzip). When filing Launchpad bugs, the zstd compressed CoreDump is attached to the bug named `CoreDump.gz`. Support zstd compressed values in `ProblemReport.write_mime`. Tested with: ``` divide-by-zero PYTHONPATH=$(pwd) APPORT_LAUNCHPAD_INSTANCE=qastaging bin/apport-cli /var/crash/_usr_bin_divide-by-zero.1000.crash ``` Bug: https://launchpad.net/bugs/2148656
bdrung
force-pushed
the
zstd-compression
branch
from
4a31139 to
67d85e3
Compare
Member
Author
|
Just rebased. |
bdrung
force-pushed
the
zstd-compression
branch
from
67d85e3 to
a36ff96
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Apport is used with systemd-coredump, the CoreDump is zstd compressed (instead of gzip). When filing Launchpad bugs, the zstd compressed CoreDump is attached to the bug named
CoreDump.gz.Support zstd compressed values in
ProblemReport.write_mime.Tested with:
LP: #2148656