apt_dpkg: simplify _fetch_contents_file#578
Merged
bdrung merged 1 commit intocanonical:mainfrom Apr 24, 2026
Merged
Conversation
Merged
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #578 +/- ##
=======================================
Coverage 84.45% 84.46%
=======================================
Files 104 104
Lines 20939 20936 -3
Branches 3212 3212
=======================================
- Hits 17685 17683 -2
Misses 2814 2814
+ Partials 440 439 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Hyask
approved these changes
Apr 24, 2026
Contributor
Hyask
left a comment
Hyask
left a comment
There was a problem hiding this comment.
The unified diff is a bit confusing, but the split one made much more sense. Maybe it's just my brain being fried. Anyway, looks good, and welcome change, thanks!
Member
Author
|
The unified diff is harder to read because of the additional indentation change. So you are not alone. |
Simplify `_fetch_contents_file` by removing the `update` variable and exit early in case there is no update needed.
bdrung
force-pushed
the
simplify_fetch_contents_file
branch
from
f76fcaf to
c1fba5d
Compare
Member
Author
|
Just rebased. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify
_fetch_contents_fileby removing theupdatevariable and exit early in case there is no update needed.