chore(terraform): update terraform modules to latest standards#125
Open
jansdhillon wants to merge 3 commits intomainfrom
Open
chore(terraform): update terraform modules to latest standards#125jansdhillon wants to merge 3 commits intomainfrom
jansdhillon wants to merge 3 commits intomainfrom
Conversation
- Update required_version to ~> 1.12 and juju provider to ~> 1.0 - Add terraform/.tflint.hcl at the terraform root with required_version rule - Add renovate.json with charmhub custom datasource for automated revision tracking - Add tftest setup modules for charm and product modules - Fix copyright year typo in outputs.tf (2026 -> 2025) - Update README docs sections to reflect new version constraints Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
… version - Revert outputs.tf copyright year to 2026 (was wrongly changed to 2025) - Add missing .github/workflows/test_terraform_modules.yaml (requires workflow PAT scope) - Update CI to use terraform ~1.12 to match required_version in modules Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The main.tftest.hcl files require a real Juju controller and should only run in the integration test workflow (test_terraform_modules.yaml with lxd-controller: true). Update Makefile targets to filter to mock-only test files for the unit test CI. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR aligns the Terraform modules with the team's latest standards.
Changes
terraform/charm/versions.tf: Updatedrequired_versionfrom>= 1.10to~> 1.12and juju provider to~> 1.0terraform/product/modules/landscape-scalable/versions.tf: Same version updatesterraform/.tflint.hcl: Added tflint config at terraform root withterraform_required_versionrule enabledrenovate.json: Added with charmhub custom datasource for automated terraform revision trackingterraform/charm/tests/main.tftest.hclandterraform/charm/tests/setup/main.tf: Added integration test setup for the charm moduleterraform/product/modules/landscape-scalable/tests/: Added integration and mock test suite for the product moduleterraform/charm/outputs.tf: Copyright year preserved as 2026terraform/charm/README.mdand product README: Updated version constraint in auto-generated docs section.github/workflows/test_terraform_modules.yaml: Added terraform integration tests workflow.github/workflows/lint.yamlandunit-test.yaml: Updated CI to use terraform~1.12to match modulerequired_versionterraform/charm/Makefileandterraform/product/Makefile: Updated unit test targets to filter to mock-only tests (integration tests inmain.tftest.hclrequire a Juju controller, handled bytest_terraform_modules.yaml)Testing
All mock-provider terraform tests pass:
This PR was opened by the charmkeeper agent.