chore(terraform): update terraform modules to latest standards

.github/workflows/lint.yaml

@@ -31,7 +31,7 @@ jobs:
       - uses: actions/checkout@v5
       - uses: hashicorp/setup-terraform@v3
         with:
-          terraform_version: "~1.10"
+          terraform_version: "~1.12"
 
       - uses: terraform-linters/setup-tflint@v4
       - run: make terraform-check-all

.github/workflows/test_terraform_modules.yaml

@@ -0,0 +1,18 @@
+# Copyright 2025 Canonical Ltd.
+# See LICENSE file for licensing details.
+
+name: Terraform modules tests
+
+on:
+  workflow_dispatch:
+  pull_request:
+    paths:
+      - 'terraform/**'
+
+jobs:
+  terraform-tests:
+    uses: canonical/operator-workflows/.github/workflows/terraform_modules_test.yaml@main
+    secrets: inherit
+    with:
+      lxd-controller: true
+      terraform-directories: '["terraform/charm", "terraform/product/modules/landscape-scalable"]'

.github/workflows/unit-test.yaml

@@ -42,7 +42,7 @@ jobs:
 
       - uses: hashicorp/setup-terraform@v3
         with:
-          terraform_version: "~1.10"
+          terraform_version: "~1.12"
 
       - name: Run terraform tests
         run: make terraform-test-all

renovate.json

@@ -0,0 +1,79 @@
+{
+  "$schema": "https://docs.renovatebot.com/renovate-schema.json",
+  "automerge": true,
+  "customDatasources": {
+    "charmhub": {
+      "defaultRegistryUrlTemplate": "https://api.charmhub.io/v2/charms/info/{{packageName}}?fields=channel-map",
+      "format": "json",
+      "transformTemplates": [
+        "{\"releases\": [{\"version\": $string($$.(`channel-map`[channel.risk = 'edge' and channel.track = 'latest' and channel.base.architecture = 'amd64' and channel.base.channel = '24.04'].revision.revision))}]}"
+      ]
+    }
+  },
+  "customManagers": [
+    {
+      "customType": "regex",
+      "datasourceTemplate": "docker",
+      "description": "Update base image references",
+      "managerFilePatterns": [
+        "/(^|/)rockcraft.yaml$/"
+      ],
+      "matchStrings": [
+        "# renovate: build-base:\\s+(?<depName>[^:]*):(?<currentValue>[^\\s@]*)(@(?<currentDigest>sha256:[0-9a-f]*))?",
+        "# renovate: base:\\s+(?<depName>[^:]*):(?<currentValue>[^\\s@]*)(@(?<currentDigest>sha256:[0-9a-f]*))?"
+      ],
+      "matchStringsStrategy": "any",
+      "versioningTemplate": "ubuntu"
+    },
+    {
+      "customType": "regex",
+      "datasourceTemplate": "custom.charmhub",
+      "fileMatch": [
+        "\\.tftest\\.hcl$",
+        "\\.tf$"
+      ],
+      "matchStrings": [
+        "# renovate: depName=\"(?<packageName>[^\"]+)\"\\s*\\n\\s*(?<fieldName>[a-zA-Z0-9_]+)\\s*=\\s*(?<currentValue>\\d+)"
+      ],
+      "versioningTemplate": "semver-coerced"
+    }
+  ],
+  "extends": [
+    "config:recommended",
+    "group:allNonMajor"
+  ],
+  "ignorePaths": [],
+  "packageRules": [
+    {
+      "enabled": true,
+      "matchDatasources": [
+        "docker"
+      ],
+      "pinDigests": true
+    },
+    {
+      "automerge": true,
+      "enabled": true,
+      "matchDatasources": [
+        "custom.charmhub"
+      ]
+    },
+    {
+      "enabled": false,
+      "matchFileNames": [
+        "rockcraft.yaml"
+      ],
+      "matchUpdateTypes": [
+        "major",
+        "minor",
+        "patch"
+      ]
+    }
+  ],
+  "schedule": [
+    "* * * * 0,6"
+  ],
+  "vulnerabilityAlerts": {
+    "enabled": true
+  }
+}

terraform/.tflint.hcl

@@ -0,0 +1,5 @@
+# © 2025 Canonical Ltd.
+
+rule "terraform_required_version" {
+  enabled = true
+}

terraform/charm/Makefile

@@ -8,7 +8,7 @@
 
 test-charm-module:
 	terraform init -backend=false && \
-	terraform test
+	terraform test -filter=tests/outputs.tftest.hcl
 
 fmt-check:
 	terraform init -backend=false && \

terraform/charm/README.md

@@ -91,7 +91,7 @@ make fix-charm-module
 
 | Name | Version |
 |------|---------|
-| <a name="requirement_terraform"></a> [terraform](#requirement\_terraform) | >= 1.10 |
+| <a name="requirement_terraform"></a> [terraform](#requirement\_terraform) | ~> 1.12 |
 | <a name="requirement_juju"></a> [juju](#requirement\_juju) | ~> 1.0 |
 
 ## Providers

terraform/charm/tests/main.tftest.hcl

@@ -0,0 +1,21 @@
+# © 2025 Canonical Ltd.
+
+run "setup_tests" {
+  module {
+    source = "./tests/setup"
+  }
+}
+
+run "basic_deploy" {
+  variables {
+    model_uuid = run.setup_tests.model_uuid
+    channel    = "latest/edge"
+    # renovate: depName="landscape-server"
+    revision = 143
+  }
+
+  assert {
+    condition     = output.app_name == "landscape-server"
+    error_message = "landscape-server app_name did not match expected"
+  }
+}

terraform/charm/tests/setup/main.tf

@@ -0,0 +1,21 @@
+# © 2025 Canonical Ltd.
+
+terraform {
+  required_version = "~> 1.12"
+  required_providers {
+    juju = {
+      version = "~> 1.0"
+      source  = "juju/juju"
+    }
+  }
+}
+
+provider "juju" {}
+
+resource "juju_model" "test_model" {
+  name = "tf-testing-${formatdate("YYYYMMDDhhmmss", timestamp())}"
+}
+
+output "model_uuid" {
+  value = juju_model.test_model.uuid
+}

terraform/charm/versions.tf

@@ -1,7 +1,7 @@
 # © 2025 Canonical Ltd.
 
 terraform {
-  required_version = ">= 1.10"
+  required_version = "~> 1.12"
   required_providers {
     juju = {
       source  = "juju/juju"

terraform/product/Makefile

@@ -24,5 +24,8 @@ test-product-modules:
 	for m in $(MODULE_PATHS); do \
 		cd $$m && \
 		terraform init -backend=false && \
-		terraform test; \
+		terraform test \
+			-filter=tests/defaults.tftest.hcl \
+			-filter=tests/outputs.tftest.hcl \
+			-filter=tests/integrations.tftest.hcl; \
 	done

terraform/product/modules/landscape-scalable/README.md

@@ -58,7 +58,7 @@ This module uses the [Landscape Server charm module](https://github.com/canonica
 
 | Name                                                                      | Version |
 | ------------------------------------------------------------------------- | ------- |
-| <a name="requirement_terraform"></a> [terraform](#requirement\_terraform) | >= 1.10 |
+| <a name="requirement_terraform"></a> [terraform](#requirement\_terraform) | ~> 1.12 |
 | <a name="requirement_juju"></a> [juju](#requirement\_juju)                | ~> 1.0  |
 
 ## Providers

terraform/product/modules/landscape-scalable/tests/main.tftest.hcl

@@ -0,0 +1,23 @@
+# © 2025 Canonical Ltd.
+
+run "setup_tests" {
+  module {
+    source = "./tests/setup"
+  }
+}
+
+run "basic_deploy" {
+  variables {
+    model_uuid = run.setup_tests.model_uuid
+    landscape_server = {
+      channel = "latest/edge"
+      # renovate: depName="landscape-server"
+      revision = 143
+    }
+  }
+
+  assert {
+    condition     = output.applications.landscape_server.app_name == "landscape-server"
+    error_message = "landscape-server app_name did not match expected"
+  }
+}

terraform/product/modules/landscape-scalable/tests/setup/main.tf

@@ -0,0 +1,21 @@
+# © 2025 Canonical Ltd.
+
+terraform {
+  required_version = "~> 1.12"
+  required_providers {
+    juju = {
+      version = "~> 1.0"
+      source  = "juju/juju"
+    }
+  }
+}
+
+provider "juju" {}
+
+resource "juju_model" "test_model" {
+  name = "tf-testing-${formatdate("YYYYMMDDhhmmss", timestamp())}"
+}
+
+output "model_uuid" {
+  value = juju_model.test_model.uuid
+}

terraform/product/modules/landscape-scalable/versions.tf

@@ -1,7 +1,7 @@
 # © 2025 Canonical Ltd.
 
 terraform {
-  required_version = ">= 1.10"
+  required_version = "~> 1.12"
   required_providers {
     juju = {
       source  = "juju/juju"