Open
Conversation
Signed-off-by: Daksh <dakshkaushik20040126@gmail.com>
Dav3-K3rn
reviewed
Oct 21, 2025
|
|
||
| struct sock_fprog prog_allow = { 0 }; | ||
| struct sock_fprog prog_allow = {0}; | ||
| struct sc_seccomp_file_header hdr = {0}; |
There was a problem hiding this comment.
Good! Initializing the sc_seccomp_file_header struct with = {0} ensures all fields start with known values.
|
|
||
| const char *profile_path = argv[1]; | ||
| FILE *file = sc_must_read_and_validate_header_from_file(profile_path, &hdr); | ||
| FILE *file = sc_must_read_and_validate_header_from_file(profile_path, &hdr); |
There was a problem hiding this comment.
Where is the implementation of sc_must_read_and_validate_header_from_file()?
Does it actually validate the header magic bytes?
Does it validate the version?
Does it handle partial reads correctly?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.