Suggestion for improvements

INSPECTION.md

@@ -0,0 +1,11 @@
+Code Inspection
+The structure of the code is clear, the function names suggest its purpose and makes it a readable code.
+
+The code is modular and separated in different files based on the functionality of the task like reading header, filter and filtering.
+
+Improvements:
+
+1. It is always better to gracefully handle errors rather than panicing, so the UX doesn't break.
+2. There should be tests, so including tests would help the user to understand the working of code and check for its robustness.
+3. If something is must, then const should be used in order to access them across the code faster.
+4. The files which opens should always be closed, so calling a destructor would be better using RAII pattern.

main.c

@@ -2,18 +2,20 @@
 
 #include "seccomp.h"
 
-int main(int argc, char **argv) {
-	if (argc != 2) {
+int main(int argc, char **argv)
+{
+	if (argc != 2)
+	{
 		die("needs seccomp profile as first argument");
 	}
 
-	struct sock_fprog  prog_allow = { 0 };
+	struct sock_fprog prog_allow = {0};
 	struct sc_seccomp_file_header hdr = {0};
 
 	const char *profile_path = argv[1];
-	FILE *file  = sc_must_read_and_validate_header_from_file(profile_path, &hdr);
+	FILE *file = sc_must_read_and_validate_header_from_file(profile_path, &hdr);
 	sc_must_read_filter_from_file(file, hdr.len_filter, &prog_allow);
 
-
 	sc_apply_seccomp_filter(&prog_allow);
+	fclose(file);
 }