fix(layout): use HollowCircle icon in WaitingContainer to match agent state standard#3359
Merged
gregpriday merged 3 commits intodevelopfrom Mar 16, 2026
Merged
Conversation
… grid
- Widen StatusContainerConfig.icon type from LucideIcon to ComponentType<{ className?: string }>
- Replace AlertCircle with STATE_ICONS.waiting (HollowCircle) in WaitingContainer
- Add WaitingContainer test verifying HollowCircle renders correctly
- Add FailedContainer regression test confirming XCircle still works with widened type
- Add location: "grid" to satisfy TerminalInstance type requirement
- Change type: "agent" to type: "claude" to match TerminalType union
Collaborator
Author
|
Review status: Ready |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WaitingContainerwas usingAlertCircle(a lucide warning icon) for the waiting agent state, while every other part of the UI (TerminalHeaderContent,DockedTerminalItem) usesHollowCirclefrom the centralSTATE_ICONSregistry interminalStateConfig.tsxAlertCircleimport inWaitingContainer.tsxwithHollowCirclefromAgentStateCircles, bringing it in line with the canonical icon vocabularyStatusContainerConfig.icontype inStatusContainer.tsxfromLucideIcontoReact.ComponentType<{ className?: string }>so it can accept custom SVG components likeHollowCirclewithout breakingFailedContaineror other consumersResolves #3274
Changes
src/components/Layout/WaitingContainer.tsx— swapAlertCircleforHollowCirclesrc/components/Layout/StatusContainer.tsx— broaden icon type to accept custom SVG componentssrc/components/Layout/__tests__/WaitingContainer.test.tsx— new test file covering icon render, popover content, and edge casesTesting
All existing checks pass. New test suite covers the corrected icon, popover terminal rows, empty state, and the
StatusContainerConfigtype compatibility with bothHollowCircleand lucide icons.