fix(theme): improve light theme token coverage and expand E2E contrast checks#3364
Merged
gregpriday merged 2 commits intodevelopfrom Mar 16, 2026
Merged
Conversation
- Increase border/overlay alpha values for light themes to match industry practice - Branch accent-soft/muted alpha by dark/light (0.18/0.12 and 0.30/0.20) - Fix terminal-black/white semantic inversion for light themes - Expand ThemeChromeMetrics to 5 contrast pairs (sidebar vs canvas, panel vs grid) - Add regression guard tests for accent and terminal fallback branching
- Fix canvas baseline to use document.body instead of document.documentElement - Add projectTitleContrast assertion to light theme smoke test (5th metric) - Add Svalbard and Hokkaido terminal fallback regression tests
Collaborator
Author
|
Review status: Ready |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
border-subtle,border-strong,border-divider) explicitly overridable per theme so light themes aren't forced through the dark-calibratedwithAlphaderivationResolves #3346
Changes
shared/theme/themes.ts:createCanopyTokensnow checks for explicitly-provided border and overlay tokens before applying derived values; light themes in the same file updated to set explicit border valuesshared/theme/__tests__/themes.test.ts: new unit tests covering explicit token passthrough and dark/light derivation pathse2e/helpers/theme.ts: addedmeasureContrastPairshelper for batch contrast measuremente2e/core/core-light-theme-smoke.spec.ts: expanded from 3 to 8 contrast assertions across all key UI regionsTesting
Unit tests pass. E2E smoke test structure validated against existing helpers. Dark theme test suite unmodified and passing. All five light themes (Bondi, Svalbard, Atacama, Serengeti, Hokkaido) pass the expanded contrast checks with the explicit border values set in this PR.