use figure/table caption numbers for anchoring #188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katamartin
reviewed
Mar 21, 2025
|
|
||
| const elementNumber = captionElement?.props?.number | ||
| const elementType = | ||
| captionElement?.type?.displayName === 'TableCaption' ? 'table' : 'figure' |
Member
There was a problem hiding this comment.
Would it be possible to infer the elementType by inspecting the label prop passed to Caption? That way, we could handle other caption labels automatically if they ever arose. Or is inspecting a grandchild's props tricky?
Member
Author
There was a problem hiding this comment.
Unfortunately, I haven't found a clean way to access Caption's props from Figure. We could potentially remove the FigureCaption and TableCaption components and just use Caption with a required label prop, but that's a bigger change than I want to do here.
This was referenced Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an id to the
Figurecomponent by looking for child table/figure caption components and using their number prop to create an id that can be used for linking to them, e.g.,carbonplan.org/research/cdr-counterfactual-accounting#figure-1orcarbonplan.org/research/cdr-counterfactual-accounting#table-1