Skip to content

Conversation

@psmithcrl
Copy link
Contributor

Please test this out and provide some feedback.
This will bind to a server process running on the camera.
Will update to include which firmware versions are compatible with this update process.

@QuentinTorg
Copy link
Collaborator

Does it make sense to remove this outdated flash utility at the same time? https://github.com/carnegierobotics/LibMultiSense/tree/master/source/Utilities/FlashUtility

@dougbalish1
Copy link
Contributor

Does it make sense to remove this outdated flash utility at the same time? https://github.com/carnegierobotics/LibMultiSense/tree/master/source/Utilities/FlashUtility

@QuentinTorg
My $0.02: Looks like it's been disabled on the camera side since 2020. I'm assuming we left it in for legacy cameras, but probably worth taking out at this point.
If we're gonna do that though, might as well trash the flash ops as a whole, might be worth splitting out into its own PR

@dougbalish1
Copy link
Contributor

#164 first

psmithcrl and others added 14 commits October 25, 2024 18:08
* Fix windows build (#158)

* add instance of static member of Timestamp, for windows_build

* fix for visual studio warning

* Add CI build (#162)

* add github action for building libmultisense

* fix one header before move to windows machine

* update some dead links

* builds on ubuntu, not tested

* test windows commit

* Dbalish/windows buildfix (#163)

* reorder includes so min/max macros don't get defined

* remove accidental newline

* WIP

* add windows style struct packing

* make message values unsigned

* builds in windows - untested

* windows build tested and working

* fix broken #defines

* last bit of cleanpup

---------

Co-authored-by: hshibatacrl <86801795+hshibatacrl@users.noreply.github.com>
Co-authored-by: Quentin Torgerson <qtorgerson@carnegierobotics.com>
Copy link
Contributor

@dougbalish1 dougbalish1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattalvarado I think it's ready, if you could just double check the changes in Portability.hh, I think everything else has been addressed. Thanks!

@dougbalish1 dougbalish1 merged commit ad3e406 into master Dec 16, 2024
2 checks passed
@dougbalish1 dougbalish1 deleted the psmithcrl/FirmwareUpdateProgress branch December 16, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants