[3.5.x] Deprecate named arguments for methods moving to macros in 3.6#2530
Merged
jackkoenig merged 2 commits into3.5.xfrom May 14, 2022
Merged
[3.5.x] Deprecate named arguments for methods moving to macros in 3.6#2530jackkoenig merged 2 commits into3.5.xfrom
jackkoenig merged 2 commits into3.5.xfrom
Conversation
These methods will start using def macros and since def macros do not supported named arguments this will be a source-incompatible change. This deprecation will warn users that they need to remove any uses of named arguments on these methods.
mwachs5
approved these changes
May 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These methods will start using def macros and since def macros do not
supported named arguments this will be a source-incompatible change.
This deprecation will warn users that they need to remove any uses of
named arguments on these methods.
This resolves the issue discussed in #2515.
This doesn't give perfect error messages, but it's not bad. For the following
You'll get the warnings:
Note as precise as one would like but it does suggest that you should stop using the names 🤷♂️
Contributor Checklist
docs/src?Type of Improvement
API Impact
Warn about impending API change in 3.6.
Backend Code Generation Impact
No impact
Desired Merge Strategy
Release Notes
In Chisel 3.6, several chisel3 utils will start using def macros which do not allow named arguments. These utils are:
Cat,Fill,FillInterleaved,PopCount,Reverse,RegEnable,ShiftRegister, andShiftRegisters.Reviewer Checklist (only modified by reviewer)
3.4.x, [small] API extension:3.5.x, API modification or big change:3.6.0)?Please Merge?