(GH-61) Fix choco install package result by esiebes · Pull Request #103 · chocolatey/cChoco

esiebes · 2017-12-13T21:58:18Z

edit comments from pullrequest 102

Supersedes #102

Related to #61

…xitcode. Some casting

esiebes · 2017-12-13T22:05:55Z

new pullrequest originally pullrequest 102.

pauby · 2018-12-12T11:08:39Z

DSCResources/cChocoPackageInstall/cChocoPackageInstall.psm1

@@ -1,4 +1,4 @@
-# Copyright (c) 2017 Chocolatey Software, Inc.


Can you remove this change from the commit?

pauby · 2018-12-12T11:13:02Z

DSCResources/cChocoPackageInstall/cChocoPackageInstall.psm1

    Write-Verbose -Message "Install command: 'choco install $pName $chocoinstallparams'"
-
-    $packageInstallOuput = Invoke-Expression -Command "choco install $pName $chocoinstallparams"
+    $packageInstallOuput = Invoke-ChocoLatey "install $pName $chocoinstallparams"


Picky but can you change Invoke-ChocoLatey to a lowercase 'l'?
Can you also add the arguments parameter explicitly?

pauby · 2018-12-12T11:19:19Z

DSCResources/cChocoPackageInstall/cChocoPackageInstall.psm1

    Write-Verbose -Message "Package output $packageInstallOuput "

-    # Clear Package Cache
-    Get-ChocoInstalledPackage 'Purge'


Is there a reason this has been removed?

the purge command can cause errors and hangs code in DSC configurations.

There are no issues submitted around the purge command. If this isn't the fix for the issue itself can you raise an issue we can look at and remove it from this PR?

pauby · 2018-12-12T11:21:35Z

DSCResources/cChocoPackageInstall/cChocoPackageInstall.psm1

    Write-Verbose -Message "Package uninstall output $packageUninstallOuput "

-    # Clear Package Cache
-    Get-ChocoInstalledPackage 'Purge'


he purge command can cause errors and hangs code in DSC configurations.

See previous comment.

I added the purge command again.

pauby · 2018-12-12T11:24:21Z

DSCResources/cChocoPackageInstall/cChocoPackageInstall.psm1

    }
-    $cmd = "choco upgrade $pName $chocoupgradeparams"
+    $cmd = "upgrade $pName $chocoupgradeparams"
    Write-Verbose -Message "Upgrade command: '$cmd'"


I'd like to keep that Verbose message consistent from what it was previously - prepend it with 'choco'?

I don't see this change in the latest commit.

Removed the choco

pauby · 2018-12-12T11:27:20Z

DSCResources/cChocoPackageInstall/cChocoPackageInstall.psm1

-    Get-ChocoInstalledPackage 'Purge'
+function Get-ChocoInstalledPackage {
+    Return (choco list -lo -r | ConvertFrom-Csv -Header 'Name', 'Version' -Delimiter "|")
 }


What's your thinking behind running this every time rather than caching it for 60 seconds?
The Return isn't needed.

In some instances of DSC configuratioin 60 seconds is to long if a small package is installed, so the test will fail I will remove the Return

See previous comment around this.

pauby · 2018-12-12T11:28:16Z

DSCResources/cChocoPackageInstall/cChocoPackageInstall.psm1

+    #Set $LASTEXITCODE variable.
+    powershell.exe   -NoLogo -NoProfile -Noninteractive "exit $exitcode"
+
+    if($exitcode -in $validExitCodes )


What happens if a non-MSI exits with one of the MSI exit codes? That could indicate an error but it's ignored?

its ignore/ non error

If an EXE exits with an error code that matches one of those we need that to come through. Ignoring it would indicate it installed it okay when in fact it didn't.

DSCResources/cChocoPackageInstall/cChocoPackageInstall.psm1

pauby · 2019-07-28T14:42:07Z

@esiebes Is this still a PR you are wanting to work on?

esiebes · 2019-07-29T12:54:41Z

yes, i will work on it asap Op zo 28 jul. 2019 16:42 schreef Paul Broadwith <notifications@github.com>:

…

@esiebes <https://github.com/esiebes> Is this still a PR you are wanting to work on? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#103?email_source=notifications&email_token=AIEO72WOUTKY5QGHITNINVDQBWV4DA5CNFSM4EIE6TEKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD27AA2I#issuecomment-515768425>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AIEO72WVMNTQ2JGIIONXJM3QBWV4DANCNFSM4EIE6TEA> .

pauby · 2019-10-03T17:04:25Z

@esiebes Are you still working on this?

pauby · 2019-10-07T20:35:50Z

DSCResources/cChocoPackageInstall/cChocoPackageInstall.psm1

    Write-Verbose -Message "Testing if $pName can be upgraded: 'choco upgrade $pName $chocoupgradeparams'"

-    $packageUpgradeOuput = Invoke-Chocolatey "upgrade $pName $chocoupgradeparams"
+    $packageUpgradeOuput = Invoke-Chocolatey "choco upgrade $pName $chocoupgradeparams"


The choco command shouldn't be passed to Invoke-Chocolatey.

pauby · 2020-05-21T16:01:02Z

@esiebes Are you still wanting to take this forward?

esiebes · 2020-05-21T16:10:19Z

Yes, will forward the changes tomorrow. Op do 21 mei 2020 18:01 schreef Paul Broadwith <notifications@github.com>:

…

@esiebes <https://github.com/esiebes> Are you still wanting to take this forward? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#103 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AIEO72RTB2W56QDGKCM4DGTRSVF45ANCNFSM4EIE6TEA> .

esiebes · 2020-05-25T16:32:33Z

I keep getting a failed test in appveyor on the psscriptanalyzer test. Local on my machine i dont get it. Someon an idea?
[-] passes the PSScriptAnalyzer Rule PSShouldProcess 986ms
Expected 0, but got 1.
[-] passes the PSScriptAnalyzer Rule PSShouldProcess 986ms
Expected 0, but got 1.
34: (Invoke-ScriptAnalyzer -Path $module.FullName -IncludeRule $rule.RuleName ).Count | Should Be 0
at , C:\projects\cchoco\tests\cChoco_ScriptAnalyzerTests.ps1: line 3434: (Invoke-ScriptAnalyzer -Path $module.FullName -IncludeRule $rule.RuleName ).Count | Should Be 0
at , C:\projects\cchoco\tests\cChoco_ScriptAnalyzerTests.ps1: line 34

pauby · 2020-06-23T11:28:19Z

Are you running the same version of PSScriptAnalzyer?

Can I also ask you to update some of those commit messages and preferably squash some of them?

esiebes · 2020-06-23T12:15:36Z

I will do that. Whih versiin is used? Op di 23 jun. 2020 13:28 schreef Paul Broadwith <notifications@github.com>:

…

Are you running the same version of PSScriptAnalzyer? Can I also ask you to update some of those commit messages and preferably squash some of them? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#103 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AIEO72VIAGJFDTYI35357TLRYCGWBANCNFSM4EIE6TEA> .

pauby · 2020-06-23T13:44:20Z

See this for the maximum version that the author believes is supported.

Also see this issue #147 for the build issues.

choco exitcode typo missed some bracket add missing function else block added, gone after merge should process with test not used add shouldprocess to Invoke chocolatey add verbose to scriptstest shouldprocess thing error no error local found with shouldprocess mm

…es/cChoco into feature/chocoinstallresult

Changes cChocoPackagesInstall to validate choco's exit code. Handles the standard exit codes as documented in Chocolatey's documentation. Fixes issue chocolatey#61 Supersedes chocolatey#103

bassedball and others added 4 commits December 4, 2017 13:56

add Invoke-Chocolatey cmdlet which throws error on choco failure

13dc62b

Merge branch 'development' into feature/chocoinstallResult

c2e80c6

removed typo

e3d87fb

removed alias, ensured LASTEXITCODE powershell is set same as choco e…

b5e589e

…xitcode. Some casting

esiebes changed the title ~~Feature/chocoinstallresult~~ Fix bug #61Feature/chocoinstallresult Dec 13, 2017

esiebes changed the title ~~Fix bug #61Feature/chocoinstallresult~~ Fix bug #6 choco install package result Dec 13, 2017

esiebes added 6 commits December 15, 2017 12:52

add lastexitcode after invoke-chocolatey, included valid exit codes

f8ad82e

some fixes

cfb4fad

removed unused variable

db65157

invoke-chocolatey now returns object array (same as chocolatey

edd29ac

inovke chocolatey now returning output

2285eed

change to output

60b5c52

esiebes mentioned this pull request Dec 21, 2017

cChocoPackageInstall doesn't check that the package was actually installed #61

Open

ferventcoder mentioned this pull request Apr 23, 2018

Fix issue #61 add invoke-chocolatey which throws error on choco error #102

Closed

ferventcoder changed the title ~~Fix bug #6 choco install package result~~ (GH-6) Fix choco install package result Jun 5, 2018

ferventcoder changed the title ~~(GH-6) Fix choco install package result~~ (GH-61) Fix choco install package result Jun 5, 2018

pauby requested review from ferventcoder and javydekoning October 2, 2018 20:01

pauby requested review from pauby and removed request for ferventcoder and javydekoning December 12, 2018 11:08

pauby requested changes Dec 12, 2018

View reviewed changes

some minor symantic changes

119a7e3

pauby requested changes Oct 7, 2019

View reviewed changes

reverted some changes

1b84d8c

esiebes added 11 commits May 25, 2020 14:41

mergeconflicts

5ce77a1

typo

36cbc0f

missed some bracket

a31199b

add missing function

f918292

else block added, gone after merge

a765b4a

should process with test not used

c62705e

add shouldprocess to Invoke chocolatey

6f99ed1

add verbose to scriptstest

ff013ba

shouldprocess thing error

8d1c67f

no error local found with shouldprocess

d6c73a3

mm

7270d0a

esiebes added 2 commits July 9, 2020 14:40

Merge branch 'feature/chocoinstallresult' of https://github.com/esieb…

7b4d50c

…es/cChoco into feature/chocoinstallresult

orck-adrouin mentioned this pull request Jun 8, 2022

(GH-61) Validate exit code when installing package #168

Open

9 tasks

corbob mentioned this pull request Jul 6, 2023

Add test-path handler to cChocoPackageInstall in case of missing ChocoInstalled.xml #177

Closed

10 tasks

		@@ -1,4 +1,4 @@
		# Copyright (c) 2017 Chocolatey Software, Inc.

Conversation

esiebes commented Dec 13, 2017 • edited by ferventcoder Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

esiebes commented Dec 13, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pauby Oct 7, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

pauby commented Jul 28, 2019

Uh oh!

esiebes commented Jul 29, 2019 via email

Uh oh!

pauby commented Oct 3, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pauby commented May 21, 2020

Uh oh!

esiebes commented May 21, 2020 via email

Uh oh!

esiebes commented May 25, 2020

Uh oh!

pauby commented Jun 23, 2020

Uh oh!

esiebes commented Jun 23, 2020 via email

Uh oh!

pauby commented Jun 23, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

esiebes commented Dec 13, 2017 •

edited by ferventcoder

Loading

pauby Oct 7, 2019 •

edited

Loading