Skip to content

fix: keybinds/mouse not unreleasing #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
UndercoverGoose merged 4 commits into from
Nov 28, 2025
Merged

fix: keybinds/mouse not unreleasing #57

UndercoverGoose merged 4 commits into from
Nov 28, 2025

Conversation

@UndercoverGoose
Copy link
Contributor

@UndercoverGoose UndercoverGoose commented Nov 25, 2025 •
edited
Loading

  • Fixes mouse unrelease events being ignored while GUIs are open
  • Fixes keys desyncing after unblocking inputs resulting from virtual state not unsetting

@UndercoverGoose UndercoverGoose linked an issue Nov 25, 2025 that may be closed by this pull request
Keybinds get stuck being held when pressing esc or using the input blocker #56
Closed
@UndercoverGoose UndercoverGoose changed the title fix: keybinds/mouse not unreleasing" fix: keybinds/mouse not unreleasing Nov 25, 2025
@UndercoverGoose UndercoverGoose added the scope: keybinds This issue involves the Minecraft keybinding hooks. label Nov 25, 2025
@UndercoverGoose UndercoverGoose mentioned this pull request Nov 25, 2025
Closed
@UndercoverGoose
Copy link
Contributor Author

UndercoverGoose commented Nov 28, 2025

Have had no problems with this implementation so far.

@UndercoverGoose UndercoverGoose merged commit f5ef32b into main Nov 28, 2025
1 check passed
@UndercoverGoose UndercoverGoose deleted the fix/keybind/stuck-keys branch November 28, 2025 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

scope: keybinds This issue involves the Minecraft keybinding hooks.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Keybinds get stuck being held when pressing esc or using the input blocker

2 participants

@UndercoverGoose