Adding sizing options for button component #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clearfeld
requested changes
Jan 4, 2025
packages/button/lib/index.tsx
Outdated
Comment on lines
169
to
187
| minWidth: "3rem", | ||
| fontSize: "0.75rem", | ||
| }, | ||
|
|
||
| [ButtonSizes.MEDIUM]: { | ||
| height: "2rem", | ||
| minWidth: "4rem", | ||
| fontSize: "1rem", | ||
| }, | ||
|
|
||
| [ButtonSizes.LARGE]: { | ||
| height: "3rem", | ||
| minWidth: "6rem", | ||
| fontSize: "1.5rem", | ||
| }, | ||
|
|
||
| [ButtonSizes.XLARGE]: { | ||
| height: "4rem", | ||
| minWidth: "8rem", |
Owner
There was a problem hiding this comment.
We probably shouldn't have a minWidth.
Collaborator
Author
There was a problem hiding this comment.
Fixed, please check again.
clearfeld
requested changes
Jan 5, 2025
Owner
clearfeld
left a comment
clearfeld
left a comment
There was a problem hiding this comment.
WHy are you removing full width???
Collaborator
Author
|
Very dumb mistake by me. Added back in full width and removed minWidth lol |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.