Skip to content

Adding sizing options for button component #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Adding sizing options for button component #32

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
546bceb
Adding sizing options for button component
AaronPatterson1 Jan 4, 2025
041291c
Removing max width for button
AaronPatterson1 Jan 4, 2025
80fb7a9
Fixing sizing mistake
AaronPatterson1 Jan 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 30 additions & 4 deletions packages/button/lib/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,12 @@ enum ButtonVariants {
LINK = "link",
}

enum ButtonSizes {
SMALL = "small",
MEDIUM = "medium",
LARGE = "large",
XLARGE = "xlarge",
}
const loadingFlash = stylex.keyframes({
"0%": { opacity: 1 },
"50%": { opacity: 0.5 },
Expand Down Expand Up @@ -57,9 +63,6 @@ const styles = stylex.create({

cursor: "pointer",

// height: "2rem",
// minWidth: "4rem",

display: "flex",
justifyContent: "center",
alignItems: "center",
Expand Down Expand Up @@ -160,12 +163,33 @@ const styles = stylex.create({
backgroundColor: "var(--cds-white, #FCFCFC)",
color: "var(--cds-white, #FCFCFC)",
},

[ButtonSizes.SMALL]: {
height: "1.5rem",
fontSize: "0.75rem",
},

[ButtonSizes.MEDIUM]: {
height: "2rem",
fontSize: "1rem",
},

[ButtonSizes.LARGE]: {
height: "3rem",
fontSize: "1.5rem",
},

[ButtonSizes.XLARGE]: {
height: "4rem",
fontSize: "2rem",
},
});

export interface ButtonProps extends React.ButtonHTMLAttributes<HTMLButtonElement> {
// size?: any;
variant?: ButtonVariants;
fullWidth?: boolean;
size?: ButtonSizes;
loading?: boolean;
disabled?: boolean;
asChild?: boolean;
Expand Down Expand Up @@ -200,6 +224,7 @@ const Button = forwardRef<HTMLButtonElement, ButtonProps & ExtendProps>(({
disabled,
asChild = false,
children,
size = ButtonSizes.MEDIUM,
...props
}, ref,) => {
const Comp = asChild ? Slot : "button";
Expand All @@ -213,6 +238,7 @@ const Button = forwardRef<HTMLButtonElement, ButtonProps & ExtendProps>(({
fullWidth && styles.fullWidth,
disabled && styles.disabled,
extend,
styles[size]
)}
disabled={disabled}
{...props}
Expand All @@ -225,4 +251,4 @@ const Button = forwardRef<HTMLButtonElement, ButtonProps & ExtendProps>(({
);
Button.displayName = "Button";

export { Button, ButtonVariants };
export { Button, ButtonVariants, ButtonSizes };