Skip to content

Conversation

@fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Mar 29, 2025

If CUDA is available, let ROOT generate the cuda.pcm file after the build, and include it in the distribution.
This fixes the current problem where a missing dictionary for a type that includes a CUDA header leads to a fatal exception.

@fwyzard
Copy link
Contributor Author

fwyzard commented Mar 29, 2025

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 29, 2025

A new Pull Request was created by @fwyzard for branch IB/CMSSW_15_0_X/master.

@cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 29, 2025

cms-bot internal usage

@fwyzard
Copy link
Contributor Author

fwyzard commented Mar 29, 2025

backport #9765

@fwyzard
Copy link
Contributor Author

fwyzard commented Mar 29, 2025

type bugfix

@cmsbuild
Copy link
Contributor

REMINDER @sextonkennedy, @mandrenguyen, @rappoccio, @antoniovilela: This PR was tested with cms-sw/cmssw#47732, please check if they should be merged together

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c60796/45280/summary.html
COMMIT: 44f1f24
CMSSW: CMSSW_15_0_X_2025-03-28-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/9766/45280/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 15 lines to the logs
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3999716
  • DQMHistoTests: Total failures: 68
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3999628
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 218 log files, 189 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@makortel
Copy link
Contributor

hold

Because of cms-sw/cmssw#47740

@cmsbuild
Copy link
Contributor

Pull request has been put on hold by @makortel
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@cmsbuild cmsbuild added the hold label Mar 31, 2025
@makortel
Copy link
Contributor

@cmsbuild, please test workflow 180.1,181.1,182.1

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c60796/45295/summary.html
COMMIT: 44f1f24
CMSSW: CMSSW_15_0_X_2025-03-31-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9766/45295/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

----- Begin Fatal Exception 31-Mar-2025 20:22:48 CEST-----------------------
An exception of category 'ExternalLHEProducer' occurred while
   [0] Processing global begin Run run: 1
   [1] Calling method for module ExternalLHEProducer/'externalLHEProducer'
Exception Message:
Child failed with exit code 1.
----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 31-Mar-2025 20:22:48 CEST-----------------------
An exception of category 'ExternalLHEProducer' occurred while
   [0] Processing global begin Run run: 1
   [1] Calling method for module ExternalLHEProducer/'externalLHEProducer'
Exception Message:
Child failed with exit code 1.
----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 31-Mar-2025 20:22:48 CEST-----------------------
An exception of category 'ExternalLHEProducer' occurred while
   [0] Processing global begin Run run: 1
   [1] Calling method for module ExternalLHEProducer/'externalLHEProducer'
Exception Message:
Child failed with exit code 1.
----- End Fatal Exception -------------------------------------------------

@makortel
Copy link
Contributor

makortel commented Apr 1, 2025

@cmsbuild, please test

According to cms-sw/cmssw#47740 (comment) these could work now

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2025

REMINDER @sextonkennedy, @antoniovilela, @rappoccio, @mandrenguyen: This PR was tested with cms-sw/cmssw#47732, please check if they should be merged together

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2025

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c60796/45322/summary.html
COMMIT: 44f1f24
CMSSW: CMSSW_15_0_X_2025-04-01-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9766/45322/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 2 errors in the following unit tests:

---> test test_DavixReadV_http had ERRORS
---> test test_DavixRead_http had ERRORS

Comparison Summary

Summary:

  • You potentially added 16 lines to the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3999716
  • DQMHistoTests: Total failures: 59
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3999637
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 218 log files, 189 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@fwyzard fwyzard closed this May 14, 2025
@fwyzard fwyzard deleted the IB/CMSSW_15_0_X/master_cuda_pcm branch May 14, 2025 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants