Add a test for missing dictionaries with CUDA headers [15.0.x] #47732
Conversation
Add a test to check that the framework handles correctly the case of edm::Wrapper<T> where: - T has a dictionary - edm::Wrapper<T> does not have a dictionary - the corresponding classes.h file includes CUDA headers
|
backport #47731 |
|
A new Pull Request was created by @fwyzard for CMSSW_15_0_X. It involves the following packages:
@cmsbuild, @fwyzard, @makortel can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
|
cms-bot internal usage |
|
please test with cms-sw/cmsdist#9766 |
|
+heterogeneous |
cmsbuild
added
fully-signed
heterogeneous-approved
and removed
pending-signatures
heterogeneous-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_15_0_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_15_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 Size: This PR adds an extra 20KB to repository Comparison SummarySummary:
|
|
+1 Size: This PR adds an extra 16KB to repository Comparison SummarySummary:
|
|
@fwyzard , cms-sw/cmssw-config#116 might not work as it will set CLING_MODULES_CACHE_PATH as comma separated list of cmssw lib dirs which clang might not like ( I guess clang needs this to be a directory instead of PATH type variable). Instead of letting root dynamically generate pcm in cmssw I would like to control it during the build phase. I am looking in to CLING_PREBUILT_MODULE_PATH which rootcling uses to search for pre-build modules. May be we should use it and build cuda.pcm with in cmssw and add |
|
OK, at this point please suggest whatever fix is needed to get this PR merged. |
|
I still have no idea why cms-sw/cmsdist#9765 is not OK, though. |
|
please test with cms-sw/cmsdist#9899 |
|
-1 Failed Tests: UnitTests Unit TestsI found 1 errors in the following unit tests: ---> test TestDQMGUIUpload had ERRORS Comparison SummarySummary:
|
|
please test with cms-sw/cmsdist#9909 |
|
+1 Size: This PR adds an extra 16KB to repository The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Comparison SummarySummary:
|
|
unhold This should go together with cms-sw/cmsdist#9909 , that has just been merged. |
|
ah... @mandrenguyen can you unhold this ? |
|
unhold |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_15_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_15_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
4 participants
PR description:
Add a test to check that the framework handles correctly the case of
edm::Wrapper<T>where:Thas a dictionaryedm::Wrapper<T>does not have a dictionaryclasses.hfile includes CUDA headersPR validation:
The new unit test currently fails, due to a known issue in the ROOT distribution (#47400).
Updating the ROOT build to generate the
cuda.pcmfile (cms-sw/cmsdist#9766) avoids the fatal exception, and lets ROOT report a missing dictionary normally.If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Backport of #47731 and #47743.