Open
Conversation
Replace LIKE pattern matching with SQLite json_each() for proper JSON array searching. The previous approach interpolated the tag parameter into a LIKE pattern, allowing SQL wildcards (%, _) and double-quotes to alter query semantics and leak data. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jessie-coco
approved these changes
Mar 9, 2026
Contributor
jessie-coco
left a comment
jessie-coco
left a comment
There was a problem hiding this comment.
SQL injection fix LGTM. Parameterized query with json_each() is the correct approach. 515/515 tests passing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
json_each()ingetItemsByTagto prevent SQL injection via LIKE wildcards (%,_) and double-quotesTest plan
%wildcard no longer matches all itemsCloses #243
🤖 Generated with Claude Code