Skip to content

Fix SQL injection in getItemsByTag (#243) #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
boot-coco wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix SQL injection in getItemsByTag (#243) #254

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions server/db.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -624,15 +624,15 @@ function initDb(dataDir) {
}

function getItemsByTag({ app_id, tag }) {
// SQLite JSON: tags is stored as '["bug","ui"]', search with LIKE
// Use json_each() for proper JSON array searching (avoids LIKE injection)
if (app_id) {
return db.prepare(
`SELECT * FROM items WHERE app_id = ? AND tags LIKE ? ORDER BY created_at DESC`
).all(app_id, `%"${tag}"%`);
`SELECT i.* FROM items i, json_each(i.tags) t WHERE i.app_id = ? AND t.value = ? ORDER BY i.created_at DESC`
).all(app_id, tag);
}
return db.prepare(
`SELECT * FROM items WHERE tags LIKE ? ORDER BY created_at DESC`
).all(`%"${tag}"%`);
`SELECT i.* FROM items i, json_each(i.tags) t WHERE t.value = ? ORDER BY i.created_at DESC`
).all(tag);
}

function getDistinctUrls(app_id = 'default') {
Expand Down
19 changes: 19 additions & 0 deletions test/db.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,6 +433,25 @@ describe('DB — V2 queries', () => {
assert.equal(items.length, 1);
});

it('getItemsByTag is not vulnerable to LIKE wildcards', () => {
dbApi.createItem({
doc: 'd', created_by: 'A',
tags: ['bug', 'ui'],
});
dbApi.createItem({
doc: 'd', created_by: 'B',
tags: ['feature'],
});

// '%' should not match all items (was vulnerable with LIKE pattern)
const wildcard = dbApi.getItemsByTag({ tag: '%' });
assert.equal(wildcard.length, 0);

// Partial match should not work — must be exact
const partial = dbApi.getItemsByTag({ tag: 'bu' });
assert.equal(partial.length, 0);
});

it('getDistinctUrls returns unique source_urls with counts', () => {
dbApi.createItem({ doc: 'd', created_by: 'A', source_url: 'https://a.com' });
dbApi.createItem({ doc: 'd', created_by: 'B', source_url: 'https://a.com' });
Expand Down