Skip to content

⚡️ Speed up method IndexVariable.to_index by 64% #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codeflash-ai wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up method IndexVariable.to_index by 64% #47

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 22 additions & 9 deletions xarray/core/variable.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2602,7 +2602,13 @@ def __init__(self, dims, data, attrs=None, encoding=None, fastpath=False):

# Unlike in Variable, always eagerly load values into memory
if not isinstance(self._data, PandasIndexingAdapter):
self._data = PandasIndexingAdapter(self._data)
# Avoid multiple conversions: if already a pd.Index, inject directly
array = self._data
if isinstance(array, pd.Index):
self._data = PandasIndexingAdapter(array)
else:
# Let PandasIndexingAdapter perform the conversion only once
self._data = PandasIndexingAdapter(array)

def __dask_tokenize__(self) -> object:
from dask.base import normalize_token
Expand Down Expand Up @@ -2784,15 +2790,22 @@ def _to_index(self) -> pd.Index:
assert self.ndim == 1
index = self._data.array
if isinstance(index, pd.MultiIndex):
# set default names for multi-index unnamed levels so that
# we can safely rename dimension / coordinate later
valid_level_names = [
name or f"{self.dims[0]}_level_{i}"
for i, name in enumerate(index.names)
]
index = index.set_names(valid_level_names)
# Only create new names if necessary
names = index.names
if any(name is None for name in names):
# set default names for multi-index unnamed levels so that
# we can safely rename dimension / coordinate later
valid_level_names = [
name if name is not None else f"{self.dims[0]}_level_{i}"
for i, name in enumerate(names)
]
index = index.set_names(valid_level_names)
else:
index = index.set_names(self.name)
current_name = index.name
# Only call set_names if name is actually different to avoid unnecessary object creation
name = self.name
if current_name != name:
index = index.set_names(name)
return index

def to_index(self) -> pd.Index:
Expand Down