Skip to content

⚡️ Speed up method RenderTree.by_attr by 15% #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codeflash-ai wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up method RenderTree.by_attr by 15% #67

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 17 additions & 17 deletions xarray/datatree_/datatree/render.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,23 +234,23 @@ def by_attr(self, attrname="name"):
└── sub1C
└── sub1Ca
"""

def get():
for pre, fill, node in self:
attr = (
attrname(node)
if callable(attrname)
else getattr(node, attrname, "")
)
if isinstance(attr, (list, tuple)):
lines = attr
else:
lines = str(attr).split("\n")
yield "%s%s" % (pre, lines[0])
for line in lines[1:]:
yield "%s%s" % (fill, line)

return "\n".join(get())
# In-place generator reduces function call overhead vs nested function
lines = []
append = lines.append
callable_attr = callable(attrname)
for pre, fill, node in self:
if callable_attr:
attr = attrname(node)
else:
attr = getattr(node, attrname, "")
if isinstance(attr, (list, tuple)):
arr_lines = attr
else:
arr_lines = str(attr).split("\n")
append("%s%s" % (pre, arr_lines[0]))
for line in arr_lines[1:]:
append("%s%s" % (fill, line))
return "\n".join(lines)


def _is_last(iterable):
Expand Down