fix: Revoke token and General Settings should be editable only by admins#830
Open
quangtuanitmo18 wants to merge 4 commits intomasterfrom
Open
fix: Revoke token and General Settings should be editable only by admins#830quangtuanitmo18 wants to merge 4 commits intomasterfrom
quangtuanitmo18 wants to merge 4 commits intomasterfrom
Conversation
quangtuanitmo18
force-pushed
the
fix/admin-revoke-token-and-general-settings
branch
from
09d297d to
8f887df
Compare
…com:codex-team/hawk.garage into fix/admin-revoke-token-and-general-settings
neSpecc
reviewed
Feb 27, 2026
| {{ $t('projects.settings.general.title') }} | ||
| </div> | ||
| <form | ||
| v-if="userCanEdit" |
Member
There was a problem hiding this comment.
For regular team members the page will be empty, it's not the best UI. It would be better to make inputs "disabled"
But first of all, the ability to change general settings on the API side. Could you check it? maybe it is already disabled.
| /> | ||
|
|
||
| <div | ||
| v-if="userCanEdit" |
Member
There was a problem hiding this comment.
same thing: API is first, UI is the next phase check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Revoke token and General Settings should be editable only by admins