Skip to content

fix: Revoke token and General Settings should be editable only by admins #830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
quangtuanitmo18 wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fix: Revoke token and General Settings should be editable only by admins #830

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
09d297d
fix: Revoke token and General Settings should be editable only by admins
quangtuanitmo18 Jan 28, 2026
8f887df
fix: Revoke token and General Settings should be editable only by admins
quangtuanitmo18 Jan 28, 2026
16d3e79
Merge branch 'master' into fix/admin-revoke-token-and-general-settings
quangtuanitmo18 Feb 27, 2026
e3397d6
Merge branch 'fix/admin-revoke-token-and-general-settings' of github.…
quangtuanitmo18 Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/components/project/settings/General.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
{{ $t('projects.settings.general.title') }}
</div>
<form
v-if="userCanEdit"
Copy link
Copy Markdown
Member

@neSpecc neSpecc Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For regular team members the page will be empty, it's not the best UI. It would be better to make inputs "disabled"

But first of all, the ability to change general settings on the API side. Could you check it? maybe it is already disabled.

class="project-settings__form"
@submit.prevent="save"
>
Expand Down Expand Up @@ -56,6 +57,8 @@ import { UPDATE_PROJECT } from '@/store/modules/projects/actionTypes';

import notifier from 'codex-notifier';

import { ConfirmedMember, Member, Workspace } from '@/types/workspaces';

/**
* This data will be send to update a project
*/
Expand Down Expand Up @@ -96,6 +99,17 @@ export default defineComponent({
required: true,
},
},
computed: {
workspace(): Workspace {
return this.$store.getters.getWorkspaceByProjectId(this.project.id);
},
currentMembership(): Member | undefined {
return this.$store.getters.getCurrentUserInWorkspace(this.workspace);
},
userCanEdit(): boolean {
return this.currentMembership ? (this.currentMembership as ConfirmedMember).isAdmin : false;
},
},
data() {
return {
/**
Expand Down
11 changes: 11 additions & 0 deletions src/components/project/settings/Integrations.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
/>

<div
v-if="userCanEdit"
Copy link
Copy Markdown
Member

@neSpecc neSpecc Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same thing: API is first, UI is the next phase check

class="projects-integrations-settings-page__revoke-container"
@click="revokeIntegrationToken()"
v-html="$t('projects.settings.integrations.revokeText')"
Expand Down Expand Up @@ -47,6 +48,7 @@ import { ActionType } from '../../utils/ConfirmationWindow/types';
import { GENERATE_NEW_INTEGRATION_TOKEN } from '@/store/modules/projects/actionTypes';
import notifier from 'codex-notifier';
import { getSentryDSN } from '../../../utils';
import { ConfirmedMember, Member, Workspace } from '@/types/workspaces';

export default defineComponent({
name: 'ProjectIntegrationsSettings',
Expand All @@ -66,6 +68,15 @@ export default defineComponent({
sentryDSN(): string {
return getSentryDSN(this.project.token);
},
workspace(): Workspace {
return this.$store.getters.getWorkspaceByProjectId(this.project.id);
},
currentMembership(): Member | undefined {
return this.$store.getters.getCurrentUserInWorkspace(this.workspace);
},
userCanEdit(): boolean {
return this.currentMembership ? (this.currentMembership as ConfirmedMember).isAdmin : false;
},
},
methods: {
/**
Expand Down
1 change: 1 addition & 0 deletions src/components/project/settings/Layout.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
<template #menu>
<div>
<router-link
v-if="isAdmin"
class="settings-window__menu-item"
:to="{ name:'project-settings-general' }"
>
Expand Down
Loading